Skip to content

Conversation

@turmelclem
Copy link
Collaborator

@turmelclem turmelclem commented Oct 27, 2025

Content

TODO, to rebase after the merge of PR 2741

This PR includes :

  • Adding the missing "CardanoDatabase" enum value to the property signed_entity_types of AggregatorFeaturesMessage
  • improve root_routes.rs test with all SignedEntityTypeDiscriminants values

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Closes #YYY

@github-actions
Copy link

Test Results

    4 files  ± 0    168 suites  ±0   25m 43s ⏱️ + 1m 32s
2 255 tests  -  9  2 255 ✅  -  9  0 💤 ±0  0 ❌ ±0 
6 939 runs   - 60  6 939 ✅  - 60  0 💤 ±0  0 ❌ ±0 

Results for commit 73e27cf. ± Comparison against base commit 3063c3e.

This pull request removes 23 and adds 14 tests. Note that renamed tests count towards both.
mithril-protocol-config ‑ aggregator_client::tests::aggregator_features::test_aggregator_features_ko_500
mithril-protocol-config ‑ aggregator_client::tests::aggregator_features::test_aggregator_features_ko_json_serialization
mithril-protocol-config ‑ aggregator_client::tests::aggregator_features::test_aggregator_features_ok_200
mithril-protocol-config ‑ aggregator_client::tests::aggregator_features::test_aggregator_features_timeout
mithril-protocol-config ‑ aggregator_client::tests::epoch_settings::test_epoch_settings_ko_500
mithril-protocol-config ‑ aggregator_client::tests::epoch_settings::test_epoch_settings_ok_200
mithril-protocol-config ‑ aggregator_client::tests::epoch_settings::test_epoch_settings_timeout
mithril-protocol-config ‑ aggregator_client::tests::test_4xx_errors_are_handled_as_remote_server_logical
mithril-protocol-config ‑ aggregator_client::tests::test_5xx_errors_are_handled_as_remote_server_technical
mithril-protocol-config ‑ aggregator_client::tests::test_non_4xx_or_5xx_errors_are_handled_as_unhandled_status_code_and_contains_response_text
…
mithril-aggregator ‑ http_server::routes::protocol_configuration_routes::tests::test_protocol_configuration_get_ko_500
mithril-aggregator ‑ http_server::routes::protocol_configuration_routes::tests::test_protocol_configuration_get_ok
mithril-aggregator ‑ http_server::routes::protocol_configuration_routes::tests::test_protocol_configuration_return_404_when_no_configuration_found
mithril-aggregator ‑ services::message::tests::protocol_configuration::get_protocol_configuration_message
mithril-aggregator ‑ services::message::tests::protocol_configuration::get_protocol_configuration_message_return_none_if_epoch_not_found
mithril-aggregator ‑ services::message::tests::protocol_configuration::get_protocol_configuration_message_with_cardano_transactions_enabled
mithril-aggregator ‑ services::message::tests::protocol_configuration::get_protocol_configuration_message_with_multiple_epochs_settings_stored
mithril-aggregator ‑ services::message::tests::protocol_configuration::get_protocol_configuration_message_without_cardano_transactions_does_not_return_signing_config
mithril-protocol-config ‑ http_client::http_impl::tests::test_get_network_configuration_retrieve_configurations_for_aggregation_next_aggregation_and_registration
mithril-protocol-config ‑ test::double::configuration_provider::tests::test_get_network_configuration
…

@turmelclem turmelclem changed the base branch from main to ctl/2692-new-aggregator-route-to-expose-protocol-config-by-epoch October 27, 2025 16:33
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@turmelclem turmelclem force-pushed the ctl/2692-new-aggregator-route-to-expose-protocol-config-by-epoch branch 2 times, most recently from 7c45773 to ad9c6b9 Compare October 28, 2025 17:30
… root route, improve test with missing signed entity types
@turmelclem turmelclem force-pushed the ctl/fix-signed-entity-types-enum-of-AggregatorFeaturesMessage-schema branch from 73e27cf to 1f6cae5 Compare October 29, 2025 08:11
@turmelclem turmelclem marked this pull request as ready for review October 29, 2025 08:12
@turmelclem turmelclem merged commit 62cabea into ctl/2692-new-aggregator-route-to-expose-protocol-config-by-epoch Oct 29, 2025
13 of 14 checks passed
@turmelclem turmelclem deleted the ctl/fix-signed-entity-types-enum-of-AggregatorFeaturesMessage-schema branch October 29, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants