refactor: use shared aggregator client for signer and aggregrator #2755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Since there will be arround ~20 requests maximum, making a module by
subject will result on a lots of modules with one or two files, not that
helpful.
+ rename `CertificateDetailsQuery` to `GetCertificateQuery` to have
an uniform convention: `{Verb}{Subject}Query`.
…in follower aggregator - use an arc for the `ApiVersionProvider` so it fit with our current DI systems
… `Http` This makes clear that this client is Http focused only and can't be extended as is to support other protocols.
Alenar
force-pushed
the
djo/2640/shared-aggregator-client-for-signer-aggregrator
branch
from
65a5b51 to
c5822d4
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
…regator Add `GetCertificatesListQuery` and `GetEpochSettingsQuery`
add `GetAggregatorFeatures`, `PostRegisterSignatureQuery`, and `PostRegisterSignerQuery` queries.
instead of an internal, copied and adapted over the signer, implementation
instead of an internal implementation
Alenar
force-pushed
the
djo/2640/shared-aggregator-client-for-signer-aggregrator
branch
from
883789a to
6bda57a
Compare
* mithril-aggregator-client from `0.1.1` to `0.1.2` * mithril-protocol-config from `0.1.1` to `0.1.2` * mithril-aggregator from `0.7.92` to `0.7.93` * mithril-signer from `0.2.274` to `0.2.275`
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
deleted the
djo/2640/shared-aggregator-client-for-signer-aggregrator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a refactor of the
mithril-aggregatorandmithril-signerto make them use the sharedAggregatorHttpClientdefined in theinternal/mithril-aggregator-clientcrate.Details
mithril-aggregator-clientmithril-protocol-config:GetAggregatorFeaturesQuery,GetCertificatesListQuery,GetEpochSettingsQuery,GetProtocolConfigurationQuery,PostRegisterSignatureQuery, andPostRegisterSignerQueryCertificateDetailsQuerytoGetCertificateQueryso all queries names follow a{Verb}{Subject}QueryschemeAggregatorClienttoAggregatorHttpClient, same for the error and result types: this makes clears that those types are fully dedicated to http and can't be easily generalized.getandpostsubmodules instead of domain based submodules (like the previouscertificate) as domain based naming would have result in a lot of submodules with two or three files maximumwith_api_version_providernow take anArcas parameter,with_relay_endpointnow take an option.test_http_compression_is_enabledthat generate to easily add a test in child crates that check that http compression is enabledmithril-protocol-configHttpMithrilNetworkConfigurationProviderto use amithril-aggregator-client::AggregatorHttpClientmithril-aggregatormithril-aggregator-client::AggregatorHttpClientmithril-signermithril-aggregator-client::AggregatorHttpClientAggregatorClienttrait to useStdResultinstead ofAggregatorClientErrorPre-submit checklist
Issue(s)
Relates to #2640