Skip to content

fix: Rust 1.91 clippy warnings #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2025
Merged

fix: Rust 1.91 clippy warnings #2757

merged 2 commits into from
Oct 31, 2025
+3 −3

Conversation

@Alenar
Copy link
Collaborator

@Alenar Alenar commented Oct 31, 2025 •
edited
Loading

Content

This PR includes fixes to the new clippy warnings appeared with the release of Rust 1.91.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@Alenar Alenar self-assigned this Oct 31, 2025
turmelclem
turmelclem approved these changes Oct 31, 2025
View reviewed changes
Copy link
Collaborator

@turmelclem turmelclem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

Test Results

    4 files  ±0    168 suites  ±0   24m 34s ⏱️ -9s
2 256 tests ±0  2 256 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 941 runs  ±0  6 941 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0f7cae1. ± Comparison against base commit ace8c04.

jpraynaud
jpraynaud approved these changes Oct 31, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alenar Alenar temporarily deployed to testing-preview October 31, 2025 11:01 — with GitHub Actions Inactive
@Alenar Alenar merged commit 0625621 into main Oct 31, 2025
41 checks passed
@Alenar Alenar deleted the djo/rust_1.91 branch October 31, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@turmelclem turmelclem turmelclem approved these changes

Assignees

@Alenar Alenar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Alenar @jpraynaud @turmelclem