Static display & horizontal against 2.0 [odessyscience version] #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2015
|
Rendered difference: |
|
@seanadkinson any idea why this test might fail/ render the test seen above differently? |
|
Hadn't looked at the tests, but it seems like it is rendering extra empty divs. How did you see the rendered difference? I just see the console output when running Might be informative to have |
|
@seanadkinson I just put both into an empty html document to check the rendering to see if they were functionally equivalent. I'll try again with bootstrap.css loaded. |
|
With bootstrap loaded they do look equivalent. So I think I can probably change the test to make it pass.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took odessyscience's branch and rebased it on 2.0 and fixed one noticed problem.