Docker test: check detached container#337
Open
ael-code wants to merge 2 commits intoinsomnia-lab:devfrom
Open
Conversation
Check if the detached container is correctly running before to test the libreant interface. In the case the container encounter some error during startup the exit code and the last log lines will be printed.
boyska
approved these changes
Jan 21, 2018
.docker/test_all.sh
Outdated
| docker run --rm -p 5000:5000 -d --name "${PREFIX}${os}" "${PREFIX}${os}" | ||
| if ! with_backoff test_libreant_homepage; then | ||
| docker run -p 5000:5000 -d --name "${PREFIX}${os}" "${PREFIX}${os}" | ||
| check_detatched_container "${PREFIX}${os}" || exit 1 |
Member
Author
There was a problem hiding this comment.
yeap there was various indentation errors. Fixed
.docker/test_all.sh
Outdated
| echo "Container state: " 1>&2 | ||
| docker container inspect $c_name --format=" Status: {{.State.Status}}" 1>&2 | ||
| docker container inspect $c_name --format=" ExitCode: {{.State.ExitCode}}" 1>&2 | ||
| echo "Container's log tail:" 1>&2 |
Member
There was a problem hiding this comment.
saxon genitive is for people only, not for things. Container last log lines: would be better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if the detached container is correctly running before to test the
libreant interface.
In the case the container encounter some error during startup the exit
code and the last log lines will be printed.