fix: make npm recovery validation tag-independent#28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-dispatch recovery fix
This is a follow-up to the v0.3.3 npm recovery workflow. It must merge before any recovery dispatch.
Avoided failure
GitHub loads the workflow from
main, but the recovery job checks out immutablev0.3.3. The prior workflow invokedscripts/verify-release-archive.sh, which was introduced after that tag and would not exist after checkout. Dispatching would have failed before archive validation. No recovery workflow was dispatched.Fix and controls
LICENSE,README.md,SHA256SUMS, andmodel-routing; rejects extras, duplicates, nested paths, and traversal paths before extractionThe recovery’s existing v0.3.3-only confirmation, public-asset SHA256 verification, existing-version refusal, provenance reconstruction, and native/launcher checks remain unchanged.
Review and validation
Independent reviewer: PASS.
actionlint .github/workflows/release-npm-recovery.ymlcargo fmt --all -- --checkcargo test -p xtask releaseDo not merge or dispatch without direct execution approval.