[MBL-19490] Invalidate inbox cache when refreshing after message send #3410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user sends a message, the inbox list is refreshed but was not invalidating the cache first, causing stale data to appear. This fix ensures the cache is cleared before refreshing, following the existing pattern used in conversationUpdated(). Affects: Student, Teacher, Parent apps Test Plan: Send a message, navigate to SENT scope, verify new message appears 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR adds a cache invalidation call before refreshing the inbox list when a RefreshListScreen action is received. The change is minimal and focused.
Positive Feedback
- Good fix: Adding
invalidateCache()beforerefresh()ensures that stale cached data is cleared, which should resolve issues where refreshing the inbox doesn't show the latest data - Consistent pattern: This matches the existing pattern used in the
conversationUpdated()method (lines 458-462) which also calls bothinvalidateCache()andrefresh()in sequence - Simple and targeted: The change is minimal and addresses a specific issue without introducing unnecessary complexity
Observations
The change looks solid. The pattern of calling invalidateCache() before refresh() is already established in this codebase at line 459, so this maintains consistency.
No issues found - the implementation is clean and follows existing conventions.
📊 Code Coverage Report✅ Student
✅ Teacher
✅ Pandautils
📈 Overall Average
|
|
Parent Install Page |
|
Teacher Install Page |
|
Student Install Page |
adamNagy56
previously requested changes
Nov 26, 2025
Contributor
adamNagy56
left a comment
adamNagy56
left a comment
There was a problem hiding this comment.
- If we cache the Sent section in the Inbox and then send a message from the People page, it doesn’t refresh automatically, it only updates after a manual refresh. This happens in both the Teacher and Parent apps.
Screen_Recording_20251126_115710_Canvas.Parent.mp4
Screen_Recording_20251126_120057_Canvas.Teacher.mp4
kristofnemere
approved these changes
Nov 26, 2025
kdeakinstructure
previously requested changes
Nov 27, 2025
Contributor
kdeakinstructure
left a comment
kdeakinstructure
left a comment
There was a problem hiding this comment.
Please fix the issue found regarding sending message from people page.
hermannakos
dismissed stale reviews from adamNagy56 and kdeakinstructure
Not in scope of this ticket. Should be separate story.
kdeakinstructure
approved these changes
Nov 27, 2025
Contributor
kdeakinstructure
left a comment
kdeakinstructure
left a comment
There was a problem hiding this comment.
Sending conversation message out of inbox is not scope of this bug ticket, as we discussed, so I approve the bugfix.
Add waitForIdle() after clicking overflow menu items to ensure the UI has settled before the test continues. This prevents race conditions where the test tries to assert on the next screen before navigation completes. Test Plan: Ran testMessageOverflowMenuForwardButton on Pixel 2 API 29 emulator and verified it passes consistently. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🧪 Unit Test Results✅ 📱 Parent App
✅ 📱 Student App
✅ 📱 Teacher App
✅ 🌅 Horizon
✅ 📦 Submodules
📊 Summary
Last updated: Fri, 28 Nov 2025 14:01:04 GMT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a user sends a message or reply, the inbox list screen should display the newly sent message immediately. However, the cache was not being invalidated before refreshing, causing stale data to appear (especially noticeable in the SENT scope).
This fix ensures the cache is properly cleared before refreshing the inbox list, following the existing pattern already established in the
conversationUpdated()method.Test Plan
refs: MBL-19490
affects: Student, Teacher, Parent
release note: Fixed an issue where newly sent messages would not appear immediately in the inbox