Skip to content

fix pinba_flush() passing null to parameter #1 of type string is deprecated #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nadrshin merged 1 commit into from
May 7, 2025
Merged

fix pinba_flush() passing null to parameter #1 of type string is deprecated #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Stopwatch/Stopwatch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,14 @@ private function flushIfTimersLimitReached(): void
{
$timersCount = count(pinba_timers_get(PINBA_ONLY_STOPPED_TIMERS));
if ($timersCount >= self::FLUSH_TIMERS_LIMIT) {
pinba_flush(null, PINBA_FLUSH_ONLY_STOPPED_TIMERS);
pinba_flush($this->getScriptName(), PINBA_FLUSH_ONLY_STOPPED_TIMERS);
}
}

private function getScriptName(): string
{
$pinbaInfo = pinba_get_info();

return $pinbaInfo['script_name'] ?? '';
}
}
2 changes: 1 addition & 1 deletion meta/phpstan/stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function pinba_timers_get(int $flag = 0): array
}

if (!function_exists('pinba_flush')) {
function pinba_flush(?string $scriptName = null, int $flags = 0): void
function pinba_flush(string $scriptName = '', int $flags = 0): void
{
}
}
Expand Down