Improve handling of generic specialization and constraints#367
Merged
Improve handling of generic specialization and constraints#367
Conversation
cirras
force-pushed
the
implicit_specialization_is_not_my_speciality
branch
from
6c19247 to
aab971b
Compare
cirras
commented
Apr 17, 2025
fourls
requested changes
Apr 22, 2025
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Looks good! I have a few minor improvement ideas and questions.
Previously, our implicit specialization required **exact** mappings of types to top-level type parameters, but open arrays can go one level deep with the type parameter as the element type.
Technically speaking, we should never be calling `NameReferenceNode::getLastName` downstream of the `readNameReference` method. It means while we're looping over each part of the name reference, we're looking at the last part of the name each time. This is a subtle correctness thing, there should be no behavior change.
We don't typically list every new method when they're being added as part of a new type.
cirras
force-pushed
the
implicit_specialization_is_not_my_speciality
branch
from
aab971b to
162bd38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was prompted by a name resolution failure caused by an implicit specialization failure, which involved a dynamic array being passed to a generic open array. It was meant to be a small improvement to the analyzer's support for implicit specialization, adding support for routines with generic open array parameters.
In testing that change, I realized that there were cases in generic specialization that necessitate full support for constraints.
Consider the following example:
With the existing behavior (no handling for the
classconstraint), we're unable to disambiguate a call toTFoo.Barwith aTArray<TObject>argument. We need to eliminate the first overload due to theclassconstraint being violated.Naturally, this had API implications (but it wasn't too big a mess):
ConstraintNodeAST nodesConstrainttype hierarchy