Draft
Conversation
(when ipp-crypto is built from source) Signed-off-by: Sylvain Bellemare <sbellem@gmail.com>
When building SDK & IPP Crypto from source with nix, the current check for the IPP source code does not work properly. That is, even though the IPP Crypto source code is there the check in the Makefile triggers the call to the ipp_source target which invokes git to update the submodule or clone the repo. In the context of a nix derivation, the source code along with the submodules is fetch at the beginning and the .git directory is removed, such that later invocations to git commands such as the one in the Makefile for the ipp_source target, fail. Also, depending on the environment, NIX_PATH may not be set and is therefore too restrictive as a check or assumes too much. A more general mechanism would be preferable. Signed-off-by: Sylvain Bellemare <sbellem@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please not that this is a draft PR and it needs some adjustments. I am putting it up so that it can benefit from feedback, and also it can be used as a patch in nix derivations that build IPP Crypto from source.
The goal of this PR is to allow building the IPP Crypto from source, and more particularly with
nix. Moreover, the PR also aims to address issues encountered when building the SDK from source, with the IPP Crypto built-from-source as well.sgx_ippcp.hrequired when building the SDK from sourceThe main thing that needs to be properly addressed is the usage of
NIX_PATHand the check for the ipp submodule, which should not trigger thegit submoduleorgit clonecommand when building from source with nix, as the ipp crypto submodule has already been fetched at the correct revision.The work in progress commit 7dd8f19 provides more detailed information, copied here below for convenience: