Use counting sort to sort in linear instead of quadratic time #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mandolaerik
commented
Nov 24, 2023
mandolaerik
commented
- remove unused method
- Use counting sort to sort in linear instead of quadratic time
Contributor
Author
|
This is a simpler alternative to #239: almost as fast (4ns instead of 2ns per field for getting the sorted fields), and no memory footprint. Thanks to Love for suggesting this approach. |
Contributor
|
Verification #12567253: fail |
Contributor
|
Verification #12570225: pass |
lwaern-intel
approved these changes
Nov 27, 2023
Contributor
lwaern-intel
left a comment
lwaern-intel
left a comment
There was a problem hiding this comment.
see my comments for my follies. Microoptimization is hard, who knew.
lwaern-intel
requested changes
Nov 29, 2023
mandolaerik
force-pushed
the
pr/use-counting-sort-to-sort-in-linear-instead-of-quadratic-time
branch
from
2e72a47 to
c70aa88
Compare
lwaern-intel
approved these changes
Nov 29, 2023
Contributor
|
Verification #12592898: pass |
mandolaerik
deleted the
pr/use-counting-sort-to-sort-in-linear-instead-of-quadratic-time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.