port_dml: Convert sys.stderr.write to print #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeliasso
force-pushed
the
aeliasso-port-dml-syswrite-to-print
branch
from
b3a124f to
d92e564
Compare
mandolaerik
reviewed
Jun 5, 2025
mandolaerik
reviewed
Jun 5, 2025
It's easy to forget the trailing newline character when using sys.stderr.write and there are some such cases. Fix by converting all of them to print calls with file=sys.stderr instead. Replace printf-style format strings with modern f-string formatting to make it more beautiful.
aeliasso
force-pushed
the
aeliasso-port-dml-syswrite-to-print
branch
from
d92e564 to
9d21bf6
Compare
mandolaerik
approved these changes
Jun 5, 2025
|
PR Verification: ❌ failure |
|
verification failure is windows hiccup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easy to forget the trailing newline character when using sys.stderr.write and there are some such cases. Fix by converting all of them to print calls with file=sys.stderr instead. Replace printf-style format strings with modern f-string formatting to make it more beautiful.