Document bank's set, get, unmapped_get -- SIMICS-23287
#404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
actually, im curious just how |
There was a problem hiding this comment.
Pull request overview
This PR adds documentation for three bank methods (set, get, and unmapped_get) that were previously undocumented, and clarifies the return behavior of unmapped_read. These methods provide simpler variants for inquiry-type accesses to banks in the SIMICS device modeling language.
- Enhanced
unmapped_readdocumentation to specify its return type and behavior when overridden - Added documentation for
set()method used for inquiry write accesses - Added documentation for
get()andunmapped_get()methods used for inquiry read accesses
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lwaern-intel
force-pushed
the
lw/23287
branch
from
2ceffbc to
744030a
Compare
lwaern-intel
commented
Dec 10, 2025
lwaern-intel
force-pushed
the
lw/23287
branch
from
744030a to
551e1fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.