-
Notifications
You must be signed in to change notification settings - Fork 5
Add lint-configuration through comments #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JonatanWaern
wants to merge
5
commits into
main
Choose a base branch
from
lint-annotations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
37f42ad
Clean trailing whitespace
JonatanWaern 004fb00
Dont move string for begin_style_check
JonatanWaern 7c46ff8
Re-enable main lint test
JonatanWaern 1840f3a
Add support for lint configuration annotations in comments
JonatanWaern f6f5e17
Introduce the USAGE.md file
JonatanWaern File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
<!-- | ||
© 2024 Intel Corporation | ||
SPDX-License-Identifier: Apache-2.0 and MIT | ||
--> | ||
# Usage Instructions | ||
This document describes general instructions and advice directed at | ||
end-users of the DML language server. For advice or details on | ||
client implementation see [clients.md](clients.md). This document | ||
_only_ pertains to details that are client-agnostic. For client-specific | ||
details consult the documentation of the client. | ||
|
||
As this file is currently a work in progress, relevant details may be | ||
missing or incomplete. | ||
|
||
## In-Line Linting Configuration | ||
It may be desireable to control linting on a per-file basis, rather than | ||
relying on the linting configuration. This can be done with in-line | ||
linting configuration inside comments. | ||
|
||
The general syntax is: | ||
`// dls-lint: <command>=<target>` | ||
Note that only one-line comments are allowed, and only if no text is between | ||
the comment start and 'dls-lint'. | ||
|
||
Currently supported commands are: | ||
* 'allow-file' Will not report the lint rule specified by \<target> for the | ||
entire file, regardless of where 'allow-file' is declared | ||
* 'allow' Will not report the lint rule specified by \<target> for the next | ||
line without a leading comment, or for the current line if declared | ||
outside a leading comment. | ||
|
||
Lint warnings will report which rule caused them in their message, which is the | ||
same identifier used for \<target>. | ||
|
||
For example | ||
``` | ||
// dls-lint: allow-file=long_lines | ||
method now_we_can_declare_this_method_with_a_really_really_really_really_long name() { | ||
|
||
// dls-lint: allow=nsp_unary | ||
// dls-lint: allow=indent_no_tabs | ||
param p = (1 ++ * | ||
4); // dls-lint: allow=indent_paren_expr | ||
} | ||
``` | ||
Will allow 'long_lines' globally, 'nsp_unary' and 'indent_no_tabs' on the | ||
`param p = (1 ++ *` line, and 'indent_paren_expr' on the `'4);` line. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.