Pass nm and objcopy as optional environment variables to build_wrapper
#448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuyGoldenberg
changed the title
nm and objcopy as optional environment variables to build_wrappernm and objcopy as optional environment variables to build_wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross-compiling Hyperscan with fat runtime enabled, the build system previously defaulted to the native objcopy and nm tools. This could lead to architecture mismatches, since the native tools might not match the target architecture produced by the cross-compiler.
This PR introduces an enhancement that allows users to specify alternative
objcopyandnmexecutables by passing them as environment variables (OBJCOPY_PATHandNM_PATH). With these variables, the build system uses the toolchain-specific versions of these utilities, ensuring that symbol renaming is performed correctly for the target architecture.