Skip to content

Conversation

@ksandowi
Copy link
Contributor

@ksandowi ksandowi commented Dec 9, 2025

Applied changes allow building Debug configuration to allow debugging on Windows

@ksandowi ksandowi marked this pull request as ready for review December 9, 2025 00:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes debug configuration settings for Windows SGX projects to enable proper debugging. The changes standardize runtime library settings and correct dependency references across multiple Visual Studio project files.

Key changes:

  • Updated runtime library settings from static to dynamic linking variants for both debug and release configurations
  • Fixed debug library dependency from sgx_urts.lib to sgx_urtsd.lib for debug builds
  • Added explicit project dependencies in the solution file and updated Visual Studio version metadata

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Windows/sgx/test_app/enclave/TestEnclave.vcxproj Changed runtime libraries to DLL variants for all configurations (Win32/x64, Debug/Release)
Windows/sgx/test_app/app/TestApp.vcxproj Updated SGX runtime library dependency to use debug version (sgx_urtsd.lib) for Debug configurations
Windows/sgx/libsgx_usgxssl/libsgx_usgxssl.vcxproj Corrected runtime library from release to debug variant for Debug configurations
Windows/sgx/libsgx_tsgxssl/libsgx_tsgxssl.vcxproj Corrected runtime library from release to debug variant for Debug configurations
Windows/sgx/SGXOpenSSLLibrary.sln Updated Visual Studio version metadata and added project dependency sections

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bgotowal bgotowal merged commit a0840d3 into intel:main Dec 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants