Skip to content

[SYCL] Store the Adapter as weak_ptr in build results #17802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2025
Merged

[SYCL] Store the Adapter as weak_ptr in build results #17802

merged 3 commits into from
Apr 8, 2025

Conversation

slawekptak
Copy link
Contributor

No description provided.

@slawekptak slawekptak marked this pull request as ready for review April 3, 2025 07:13
@slawekptak slawekptak requested a review from a team as a code owner April 3, 2025 07:13
vinser52
vinser52 reviewed Apr 4, 2025
View reviewed changes
Copy link
Contributor

@vinser52 vinser52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change impact the performance?

@slawekptak
Copy link
Contributor Author

Does this change impact the performance?

This change should reduce the shared_ptr copies on the fast path by 2, right? I haven't measured this one, but this is one of the changes in the series of shared_ptr optimizations, so I would expect that overall the performance should be better.

@vinser52
Copy link
Contributor

vinser52 commented Apr 4, 2025

Does this change impact the performance?

This change should reduce the shared_ptr copies on the fast path by 2, right? I haven't measured this one, but this is one of the changes in the series of shared_ptr optimizations, so I would expect that overall the performance should be better.

Thank you! That was exactly my question: if this change impacts the hot path.

KseniyaTikhomirova
KseniyaTikhomirova reviewed Apr 7, 2025
View reviewed changes
KseniyaTikhomirova
KseniyaTikhomirova approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@KseniyaTikhomirova KseniyaTikhomirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slawekptak slawekptak marked this pull request as draft April 7, 2025 11:27
@slawekptak slawekptak marked this pull request as ready for review April 7, 2025 12:14
@uditagarwal97 uditagarwal97 merged commit 4c22448 into intel:sycl Apr 8, 2025
36 of 37 checks passed
@slawekptak
Copy link
Contributor Author

Does this change impact the performance?

This change should reduce the shared_ptr copies on the fast path by 2, right? I haven't measured this one, but this is one of the changes in the series of shared_ptr optimizations, so I would expect that overall the performance should be better.

Thank you! That was exactly my question: if this change impacts the hot path.

Just to clarify - this affects the cache insertion flow, so once in a stable state, it seems like it doesn't affect the fast path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinser52 vinser52 vinser52 approved these changes

@KseniyaTikhomirova KseniyaTikhomirova KseniyaTikhomirova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slawekptak @vinser52 @KseniyaTikhomirova @uditagarwal97