-
Notifications
You must be signed in to change notification settings - Fork 798
[CI] Don't run SYCL testing for changes that only affect UR #17808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
couple files in the root dir we wouldn't want to run CI for like the README.md etc, from the discussion in this issue last year oneapi-src/unified-runtime#1511 maybe do the opposite and only run CI jobs if the change touches |
Only needs to be |
I think this workflow is also relevant sycl-detect-changes.yml as its the one that runs before the other workflows and decides which actually run. |
@martygrant A quick skim of the docs suggests that it's non-trivial to add rules to both "allow" and "disallow" paths, and such a thing feels like it would be confusing to understand. Also, if some new directory gets added in the future without updating this, I think it's better to accidentality run more jobs than to skip jobs that could fail.
@kbenzie I had a look into that, but to use it I think I would have to have the job have a long list of |
A number of changes to UR won't have any observable effects on SYCL builds, so no point in running a full SYCL build and e2e test for them.
Title needs to be updated. It's not all UR changes that skip CI. |
A number of changes to UR won't have any observable effects on SYCL
builds, so no point in running a full SYCL build and e2e test for them.