Skip to content

[SYCL][E2E] Fix flaky failure of Basic/image/image_max_size.cpp #17834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

uditagarwal97
Copy link
Contributor

This test requires a significant amount of host memory. It has been observed that sometimes (very rarely) the test may fail with OUT_OF_HOST_MEMORY error, especially when run in parallel with other "high-overhead" tests. Refer CMPLRLLVM-66341.

This PR makes the test ignore failure if that happens. An alternative is to check for the available host memory and skip the test if it is too low. However, that approach is still susceptible to race conditions.

@uditagarwal97 uditagarwal97 self-assigned this Apr 3, 2025
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner April 3, 2025 18:02
Copy link
Contributor

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I laughed, I cried, it became a part of me. 5 stars.

@uditagarwal97
Copy link
Contributor Author

Gen12 failure is an infrastructure issue, it's also visible in the post commit.

@uditagarwal97 uditagarwal97 merged commit c7dbbef into sycl Apr 4, 2025
32 of 35 checks passed
@bader bader deleted the host_memory branch April 4, 2025 22:44
KornevNikita pushed a commit that referenced this pull request May 27, 2025
…7834)

This test requires a significant amount of host memory. It has been
observed that sometimes (very rarely) the test may fail with
OUT_OF_HOST_MEMORY error, especially when run in parallel with other
"high-overhead" tests. Refer CMPLRLLVM-66341.

This PR makes the test ignore failure if that happens. An alternative is
to check for the available host memory and skip the test if it is too
low. However, that approach is still susceptible to race conditions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants