Skip to content

[SYCL] Cleanup bindless images lit setup #18220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025

Conversation

npmiller
Copy link
Contributor

  • Add link-directx substitution
  • Move bindless specific substitutions to bindless directory

Follow up from: #18202

* Add link-directx substitution
* Move bindless specific substitutions to bindless directory
Copy link
Contributor

@ProGTX ProGTX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is much nicer!

@npmiller npmiller force-pushed the bindless-lit-cleanup branch from 5844b81 to b38f222 Compare May 5, 2025 10:28
@npmiller npmiller temporarily deployed to WindowsCILock May 5, 2025 10:29 — with GitHub Actions Inactive
@npmiller
Copy link
Contributor Author

npmiller commented May 5, 2025

ping @intel/llvm-reviewers-runtime @uditagarwal97 this is a small lit config cleanup

@npmiller
Copy link
Contributor Author

npmiller commented May 6, 2025

@intel/llvm-gatekeepers this is ready to merge

@kbenzie kbenzie merged commit 22ed675 into intel:sycl May 6, 2025
36 of 38 checks passed
przemektmalon added a commit to codeplaysoftware/intel-llvm-mirror that referenced this pull request May 7, 2025
The addition of "vulkan" to `config.available_features` was moved to
`bindless_images/lit.local.cfg` in intel#18220. This broke the
`// REQUIRES: vulkan` directive, and tests were reporting as being
unsupported despite vulkan being available on the system.

This patch moves the check and addition of vulkan to the available
features back to `test-e2e/lit.cfg.py` to fix the issue.
martygrant pushed a commit that referenced this pull request May 8, 2025
The addition of "vulkan" to `config.available_features` was moved to
`bindless_images/lit.local.cfg` in #18220. This broke the `// REQUIRES:
vulkan` directive, and tests were reporting as being unsupported despite
vulkan being available on the system.

This patch moves the check and addition of vulkan to the available
features back to `test-e2e/lit.cfg.py` to fix the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants