Skip to content

Conversation

@dklochkov-emb
Copy link
Contributor

@dklochkov-emb dklochkov-emb commented May 12, 2025

PR fixes tests
SYCL :: GroupAlgorithm/exclusive_scan_sycl2020.cpp
SYCL :: GroupAlgorithm/inclusive_scan_sycl2020.cpp
SYCL :: GroupAlgorithm/reduce_sycl2020.cpp

due to becoming invalid in case of binary_op is logical_or and logical_and.
Spec has Mandates for each group algorithm which tells that binary_op:
binary_op(init, *first) must return a value of type T.
etc. but logical_or and logical_and in ABI breaking mode has return type boolean

@dklochkov-emb dklochkov-emb self-assigned this May 12, 2025
@dklochkov-emb dklochkov-emb requested a review from a team as a code owner May 12, 2025 11:28
@dklochkov-emb
Copy link
Contributor Author

@aelovikov-intel Please, could you review again?

@aelovikov-intel aelovikov-intel changed the title [SYCL] remove logical_or and logical_and from group algorithm tests [SYCL] Remove logical_or and logical_and from group algorithm tests Oct 16, 2025
@@ -0,0 +1,174 @@
// RUN: %clangxx -fsycl -Xclang -verify=expected -fpreview-breaking-changes -fsyntax-only -ferror-limit=0 %s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That file should go to sycl/test, not sycl/test-e2e. You'd also be able to simplify the test by doing device compilation only and avoiding all the queue/submit/handler/etc. Check existing negative tests there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd also be able to simplify the test by doing device compilation only and avoiding all the queue/submit/handler/etc. Check existing negative tests there.

How exactly is this

Done, thanks

?

Copy link
Contributor Author

@dklochkov-emb dklochkov-emb Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aelovikov-intel Sorry, forgot about it. Reworked to avoid queues, submit etc.

@dklochkov-emb
Copy link
Contributor Author

@aelovikov-intel Please, take a look

@AlexeySachkov
Copy link
Contributor

This PR only changed tests, so the following failure is unrelated:

Failed Tests (1):
  SYCL :: ESIMD/unified_memory_api/copyto_copyfrom_slm_acc_pvc.cpp

@AlexeySachkov AlexeySachkov merged commit 3a8ad28 into intel:sycl Oct 30, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants