-
Notifications
You must be signed in to change notification settings - Fork 803
[SYCL] Remove logical_or and logical_and from group algorithm tests
#18411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Remove logical_or and logical_and from group algorithm tests
#18411
Conversation
|
@aelovikov-intel Please, could you review again? |
logical_or and logical_and from group algorithm tests
sycl/test-e2e/GroupAlgorithm/logical_or_and_group_algorithms.cpp
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,174 @@ | |||
| // RUN: %clangxx -fsycl -Xclang -verify=expected -fpreview-breaking-changes -fsyntax-only -ferror-limit=0 %s | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That file should go to sycl/test, not sycl/test-e2e. You'd also be able to simplify the test by doing device compilation only and avoiding all the queue/submit/handler/etc. Check existing negative tests there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd also be able to simplify the test by doing device compilation only and avoiding all the queue/submit/handler/etc. Check existing negative tests there.
How exactly is this
Done, thanks
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aelovikov-intel Sorry, forgot about it. Reworked to avoid queues, submit etc.
sycl/test-e2e/GroupAlgorithm/logical_or_and_group_algorithms.cpp
Outdated
Show resolved
Hide resolved
|
@aelovikov-intel Please, take a look |
|
This PR only changed tests, so the following failure is unrelated: |
PR fixes tests
SYCL :: GroupAlgorithm/exclusive_scan_sycl2020.cpp
SYCL :: GroupAlgorithm/inclusive_scan_sycl2020.cpp
SYCL :: GroupAlgorithm/reduce_sycl2020.cpp
due to becoming invalid in case of binary_op is logical_or and logical_and.
Spec has Mandates for each group algorithm which tells that binary_op:
binary_op(init, *first) must return a value of type T.
etc. but logical_or and logical_and in ABI breaking mode has return type boolean