Skip to content

[SYCL][E2E] Add local_accessor and accessor tests for sycl_ext_oneapi_free_function_kernels extension #18672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dyniols
Copy link
Contributor

@dyniols dyniols commented May 26, 2025

This PR adds new e2e tests for free function kernels extension based on test plan https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/FreeFunctionKernels/test-plan.md

@dyniols dyniols temporarily deployed to WindowsCILock May 26, 2025 15:13 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock May 26, 2025 15:51 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock May 26, 2025 15:51 — with GitHub Actions Inactive
@dyniols dyniols changed the title [SYCL][E2E] Add new tests for sycl_ext_oneapi_free_function_kernels extension [SYCL][E2E] Add local_accessor and accessor e2e tests for sycl_ext_oneapi_free_function_kernels extension May 30, 2025
@dyniols dyniols marked this pull request as ready for review May 30, 2025 09:07
@dyniols dyniols requested a review from a team as a code owner May 30, 2025 09:07
@dyniols dyniols requested a review from aelovikov-intel May 30, 2025 09:07
@dyniols
Copy link
Contributor Author

dyniols commented May 30, 2025

Closing PR and enabling it back again to rerun CI

@dyniols dyniols closed this May 30, 2025
@dyniols dyniols reopened this May 30, 2025
@dyniols dyniols temporarily deployed to WindowsCILock May 30, 2025 09:08 — with GitHub Actions Inactive
@dyniols dyniols changed the title [SYCL][E2E] Add local_accessor and accessor e2e tests for sycl_ext_oneapi_free_function_kernels extension [SYCL][E2E] Add local_accessor and accessor tests for sycl_ext_oneapi_free_function_kernels extension May 30, 2025
@dyniols dyniols temporarily deployed to WindowsCILock May 30, 2025 09:29 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock May 30, 2025 09:29 — with GitHub Actions Inactive
@aelovikov-intel
Copy link
Contributor

It would we much more effective if someone already familiar with the test plan would be reviewing this.

@dyniols dyniols temporarily deployed to WindowsCILock June 2, 2025 12:08 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock June 2, 2025 12:29 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock June 2, 2025 12:29 — with GitHub Actions Inactive
@dyniols dyniols requested a review from cperkinsintel June 2, 2025 12:38
@dyniols dyniols temporarily deployed to WindowsCILock June 4, 2025 13:55 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock June 4, 2025 17:46 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock June 4, 2025 18:18 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock June 4, 2025 18:18 — with GitHub Actions Inactive
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small stylistic nit, but otherwise I think it's there! 👍

@dyniols dyniols temporarily deployed to WindowsCILock June 5, 2025 08:41 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock June 5, 2025 09:01 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock June 5, 2025 09:01 — with GitHub Actions Inactive
@dyniols
Copy link
Contributor Author

dyniols commented Jun 5, 2025

@intel/llvm-gatekeepers It should be ready to be merged.

@sarnex sarnex merged commit f4c367b into intel:sycl Jun 5, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants