[SYCL] Add "ext_oneapi_offload" backend enum value#18683
Merged
kbenzie merged 2 commits intointel:syclfrom Jun 5, 2025
Merged
Conversation
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
This adds `offload` as a backend to the sycl runtime. This means it is accepted as a value for `ONEAPI_DEVICE_SELECTOR` and friends, and prevents an offload device reporting itself as such causing an exception to be thrown. Note that the UR offload adapter is still not built as part of the build. The only way to use this is with a standalone build of unified-runtime with libur_adapter_offload enabled and in the `LD_LIBRARY_PATH`.
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
|
@intel/llvm-reviewers-runtime @callumfare @kbenzie Now this is green, can I get it looked at? Basically, as part of offload work we want to be able to do |
aelovikov-intel
approved these changes
Jun 4, 2025
kbenzie
approved these changes
Jun 5, 2025
Contributor
Author
|
@intel/llvm-gatekeepers Please merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
offloadas a backend to the sycl runtime. This means it isaccepted as a value for
ONEAPI_DEVICE_SELECTORand friends, andprevents an offload device reporting itself as such causing an exception
to be thrown.
Note that the UR offload adapter is still not built as part of the
build. The only way to use this is with a standalone build of
unified-runtime with libur_adapter_offload enabled and in the
LD_LIBRARY_PATH.