-
Notifications
You must be signed in to change notification settings - Fork 788
[ESIMD][NFC] Extract ESIMD handling from sycl-post-link to library. #18684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
This change extracts handleESIMD from sycl-post-link to SYCLPostLink component for reuse in NewOffloading compilation flow in clang and for reuse in sycl-jit. The documentation of lowerESIMDConstructs are fixed and the argument name is changed to more straightforward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Minor nit.
I also have a question. Will it be reasonable to add a unittest for testing this functionality?
(location: llvm/unittests)
Not a blocker though.
Thanks
Speaking of the testing, different parts are being tested by LIT tests by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a few nits.
Hi @maksimsab |
This change extracts handleESIMD from sycl-post-link to SYCLPostLink component for reuse in NewOffloading compilation flow in clang and for reuse in sycl-jit.
The body of
handleESIMD
function is refactored for better readability.The documentation of lowerESIMDConstructs is fixed and the argument name is changed to more straightforward.