[ESIMD][NFC] Extract ESIMD handling from sycl-post-link to library. #18684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change extracts handleESIMD from sycl-post-link to SYCLPostLink component for reuse in NewOffloading compilation flow in clang and for reuse in sycl-jit. The documentation of lowerESIMDConstructs are fixed and the argument name is changed to more straightforward.
sarnex
approved these changes
May 27, 2025
asudarsa
reviewed
May 27, 2025
asudarsa
approved these changes
May 27, 2025
maksimsab
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Speaking of the testing, different parts are being tested by LIT tests by |
maksimsab
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
maarquitos14
approved these changes
Jun 16, 2025
|
Hi @maksimsab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extracts handleESIMD from sycl-post-link to SYCLPostLink component for reuse in NewOffloading compilation flow in clang and for reuse in sycl-jit.
The body of
handleESIMDfunction is refactored for better readability.The documentation of lowerESIMDConstructs is fixed and the argument name is changed to more straightforward.