[ESIMD][NFC] Extract ESIMD handling from sycl-post-link to library. #18684
Conversation
This change extracts handleESIMD from sycl-post-link to SYCLPostLink component for reuse in NewOffloading compilation flow in clang and for reuse in sycl-jit. The documentation of lowerESIMDConstructs are fixed and the argument name is changed to more straightforward.
| "Split modules aren't expected to be more than 2."); | ||
| if (Result.size() == 2 && SplitOccurred && | ||
| SplitMode == module_split::SPLIT_PER_KERNEL && !SplitESIMD) | ||
| return createStringError("SYCL and ESIMD entry points detected with " |
There was a problem hiding this comment.
I'm not sure I understand this error message. Does it mean that if the modules contain both SYCL and ESIMD entry points, then split-mode=per-kernel and split-esimd=false are incompatible?
There was a problem hiding this comment.
size == 2 means that we have at least 1 ESIMD entry point and at least 1 non-ESIMD entry point.
-split-esimd=false would lead to linking 2 entry points into common module.
SPLIT_PER_KERNEL dictates that one module should contain only 1 entry point.
This is a controversial state that has been initially mentioned in the comment. However, there is a aspect that it has been initially a warning while my PR makes this an error which is not NFC. I could consider to leave it as a warning.
There was a problem hiding this comment.
I'm not against the error, but the wording is quite confusing to me. I'd go for something like "--split-esimd=false is incompatible with split-mode=per-kernel".
There was a problem hiding this comment.
In fact, -split-esimd=false is compatible with split by kernel in terms of input arguments. The problem in that place is a combination of factors: Result.size() == 2, -split-esimd=false and split-mode=per-kernel.
The following combination is alright: Result.size() == 1, split-esimd=false, split-mode=per-kernel.
maksimsab
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Speaking of the testing, different parts are being tested by LIT tests by |
maksimsab
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
This change extracts handleESIMD from sycl-post-link to SYCLPostLink component for reuse in NewOffloading compilation flow in clang and for reuse in sycl-jit.
The body of
handleESIMDfunction is refactored for better readability.The documentation of lowerESIMDConstructs is fixed and the argument name is changed to more straightforward.