-
Notifications
You must be signed in to change notification settings - Fork 769
[CI][UR][Offload] Add Offload build-only job #18700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
build_type: [Release] | ||
compiler: [{c: gcc, cxx: g++}] | ||
|
||
runs-on: "ubuntu-24.04" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to use one of our build runners? i expect these ones are really slow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we should do this, any reason you didn't already @RossBrunton ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason other than the fact that ur-source-checks
and ur-benchmarks
don't. What runner should I be using for this? It doesn't need any fancy GPUs or libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we should use a UR CI machine, @igchor any ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've set the job to use [ "self-hosted", "Linux", "build" ]
, which means it should use any runner that is free to build it. This matches the sycl build jobs.
|
||
- name: Build | ||
# This is so that device binaries can find the sycl runtime library | ||
run: cmake --build build -j $(nproc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you add -GNinja
to the cmake you don't need -j
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using Make to be consistent with the ur-build-hw jobs.
Add a new job that verifies that the offload adapter can be built. It does not attempt to run any tests or detect any hardware.
Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
Add a new job that verifies that the offload adapter can be built.
It does not attempt to run any tests or detect any hardware.