[Bindless][UR][E2E] Fix/improve Vulkan tests. Fix L0 BI aspect query. #18705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Vulkan interop tests did not correctly check for the `ext-oneapi-bindless-images` aspect. This lead to failures when devices (e.g. iGPU) supported memory import, but did not support Bindless Images. Adding the `// REQUIRES` lit directive fixed this issue for iGPU, however, it caused problems for Intel BMG machines, which do not pass the aspect query as it is currently implemented. To fix this, the query now returns Bindless Image support based on extensions returned from `zeDriverGetExtensionProperties`. The `env` vars set by LIT in the `buffer_usm.cpp` test are unnecessary and have been removed. This was causing a problem on iGPU where the interop would usually work, but the test was failing due to the `env` variables set for Bindless Images. A number of improvements have been made to `vulkan_common.hpp`. There is now a clearer distinction between required and optional instance and device extensions. Optional extensions are loaded only when supported. Fetching function pointers for optional extensions is now protected so that devices with no support do not try to attempt to retrieve pointers to those functions. The `VK_IMAGE_USAGE_STORAGE_BIT` was removed from image creation as it was not necessary to the functionality of the tests. The size of the depth texture created in `depth_format.cpp` was increased due to larger minimum memory allocation size requirements on iGPU.
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
ProGTX
approved these changes
May 28, 2025
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Friendly ping @intel/unified-runtime-reviewers-level-zero |
pbalcer
approved these changes
Jun 2, 2025
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers This is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Vulkan interop tests did not correctly check for the
ext-oneapi-bindless-imagesaspect. This lead to failures when devices (e.g. iGPU) supported memory import, but did not support Bindless Images.Adding the
// REQUIRESlit directive fixed this issue for iGPU, however, it caused problems for Intel BMG machines, which do not pass the aspect query as it is currently implemented.To fix this, the query now returns Bindless Image support based on extensions returned from
zeDriverGetExtensionProperties.The
envvars set by LIT in thebuffer_usm.cpptest are unnecessary and have been removed. This was causing a problem on iGPU where the interop would usually work, but the test was failing due to theenvvariables set for Bindless Images.A number of improvements have been made to
vulkan_common.hpp. There is now a clearer distinction between required and optional instance and device extensions. Optional extensions are loaded only when supported. Fetching function pointers for optional extensions is now protected so that devices with no support do not try to attempt to retrieve pointers to those functions.The
VK_IMAGE_USAGE_STORAGE_BITwas removed from image creation as it was not necessary to the functionality of the tests.The size of the depth texture created in
depth_format.cppwas increased due to larger minimum memory allocation size requirements on iGPU.