[SYCL][UR][OpenCL] allow passing events from multiple contexts to urEventWait #18711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igchor
force-pushed
the
opencl_wait_m_context
branch
from
11e0f73 to
6c5ee12
Compare
igchor
force-pushed
the
opencl_wait_m_context
branch
from
6c5ee12 to
b22212e
Compare
aarongreig
reviewed
May 29, 2025
igchor
force-pushed
the
opencl_wait_m_context
branch
from
baa1c2a to
eb7e401
Compare
igchor
force-pushed
the
opencl_wait_m_context
branch
from
5f55b69 to
d6ef618
Compare
igchor
force-pushed
the
opencl_wait_m_context
branch
from
d6ef618 to
f605383
Compare
igchor
force-pushed
the
opencl_wait_m_context
branch
from
f605383 to
b399dea
Compare
|
The failure is unrelated - v2 adapter is failing |
aarongreig
reviewed
May 30, 2025
aarongreig
approved these changes
Jun 3, 2025
|
@intel/llvm-gatekeepers this is ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYCL allows creating cross-context dependencies. It automatically handles cases where contexts are from different adapters. However, events from a single adapter are always passed directly to urEventWait (even if they are from different contexts). This causes problems with opencl CPU (it returns CL_INVALID_CONTEXT from clWaitForEvents). In general, OpenCL spec does not guarantee that passing events from different contexts works for any function. The same problem exists for all enqueue functions but in practice SYCL does not mix events in the waitList - it will always use urEventWait for synchronization.