[NFC][SYCL] enable_shared_from_this for queue_impl
#18715
Merged
+134
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to pass an ugly `Self` in multiple methods after this. Further simplifications enabled by this change are left for subsequent PRs.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
force-pushed
the
queue-impl-shared-from-this
branch
from
0586293 to
18cebb5
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@reble , @intel/sycl-graphs-reviewers , ping |
EwanC
approved these changes
May 30, 2025
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 3, 2025
…ared` And once that is guaranteed, inherit it from `std::enable_shared_from_this`. Further simplifications based on `[shared|weak]_from_this` are left to subsequent PRs. Earlier related PRs: intel#18715 same for `queue_impl` intel#18227 same for `device_impl` intel#18141 similar for `platform_impl`
aelovikov-intel
added a commit
that referenced
this pull request
Jun 4, 2025
…ared` (#18795) And once that is guaranteed, inherit it from `std::enable_shared_from_this`. Further simplifications based on `[shared|weak]_from_this` are left to subsequent PRs. Earlier related PRs: #18715 same for `queue_impl` #18227 same for `device_impl` #18141 similar for `platform_impl` Co-authored-by: andrei.elovikov <[email protected]>
aelovikov-intel
added a commit
that referenced
this pull request
Jun 9, 2025
…e_impl` (#18748) `foo(const std::shared_ptr<queue_impl> &)` doesn't provide any information about possible `nullptr` arguments. It could provide information about possibility of creating a copy if used sparsely, but when entire codebase passes all objects like this it's meaningless too. Instead of that, the WIP refactoring across the entire codebase is to pass by raw ptr/ref (depending on the possibility of `nullptr` value) and extending lifetimes with explicit `shared_from_this()`. This PR is limited to `graph_impl.hpp` interfaces accepting `queue_impl`, clean up after #18715.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 9, 2025
Continuation of the refactoring in intel#18715 intel#18748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to pass an ugly
Selfin multiple methods after this. Further simplifications enabled by this change are left for subsequent PRs.