[SYCL] Update time bases when submit time exceeds start time #18717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently for command buffers there is a workaround to set submission time to start time if the recorded submit time is greater than the start time. This is needed because the submission time is based on estimated clock and over time device time and host time may drift apart causing aforementioned estimation to be inaccurate. I belive same "workaround" should be used for all tasks, not only for command buffers. More over it seems like this condition can be used as a trigger to query synchronized clock from backend, i.e. to correct the estimation. This PR implements that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for command buffers there is a workaround to set submission time
to start time if the recorded submit time is greater than the start time.
This is needed because the submission time is based on estimated clock
and over time device time and host time may drift apart causing
aforementioned estimation to be inaccurate.
I belive same "workaround" should be used for all tasks, not only for
command buffers.
More over it seems like this condition can be used as a trigger to query
synchronized clock from backend, i.e. to correct the estimation. This PR
implements that.