Skip to content

[L0] Revert copy engine refactor and disable copy-engine for SYCL-Graph on DG2 #18720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

EwanC
Copy link
Contributor

@EwanC EwanC commented May 29, 2025

Revert [L0] Refactor Copy Engine Usage checks for Performance and always disable copy-engine in SYCL-Graph on DG2 as a workaround for CMPLRLLVM-68064.

@EwanC EwanC temporarily deployed to WindowsCILock May 29, 2025 08:44 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock May 29, 2025 09:07 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock May 29, 2025 09:07 — with GitHub Actions Inactive
@EwanC EwanC force-pushed the ewan/graph_dg2_copy_engine branch from 0469853 to 6ac07e0 Compare May 29, 2025 09:46
Always disable copy engine usage on DG2 to as a workaround
to CI fails, see CMPLRLLVM-68064
@EwanC EwanC force-pushed the ewan/graph_dg2_copy_engine branch from 6ac07e0 to a207347 Compare May 29, 2025 09:50
@EwanC EwanC temporarily deployed to WindowsCILock May 29, 2025 09:51 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock May 29, 2025 10:10 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock May 29, 2025 10:10 — with GitHub Actions Inactive
@EwanC EwanC changed the title [WIP][SYCL][GRAPH] Do not merge: Test disabling DG2 copy engine [L0] Revert copy engine refactor and disable copy-engine for SYCL-Graph on DG2 May 29, 2025
@EwanC EwanC marked this pull request as ready for review May 29, 2025 14:45
@EwanC EwanC requested review from a team as code owners May 29, 2025 14:45
@EwanC EwanC requested a review from konradkusiak97 May 29, 2025 14:45
@EwanC
Copy link
Contributor Author

EwanC commented May 30, 2025

@intel/llvm-gatekeepers Can we merge this please, the BMG CI fails are tracked as an unrelated CI issue #18731

Edit: I've actually tried running the jobs again, since it looks like the BMG jobs might be working on other PRs now, so let's wait to see what they do.
Edit Edit:: They passed 😃

@martygrant martygrant merged commit bc10261 into intel:sycl May 30, 2025
90 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants