-
Notifications
You must be signed in to change notification settings - Fork 795
[GHA] Uplift Linux IGC Dev RT version to igc-dev-f8ec694 #18818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@intel/dpcpp-devops-reviewers, it looks like no one really cares about igc-dev updates anymore. Can we disable GHA workflow for updating igc-dev? |
Is it true that we don't care about igc-dev? @YuriPlyakhin @dkhaldi @jsji If so I would really like to remove it from everything. |
The major user is joint-matrix team. If @YuriPlyakhin @dkhaldi don't care, then yes, we can remove it from pre-commit. |
I'm not currently actively working on Joint matrix, so I'll let @dkhaldi decide. |
What I see is that no one from @intel/sycl-matrix-reviewers, @intel/dpcpp-esimd-reviewers and @intel/dpcpp-devops-reviewers groups look at the CI failures in these PRs. GHA script creates PRs each week trying to update the driver version, but AFAIK @YuriPlyakhin is the only beneficiary of this script. If he is not going to analyze CI failures, I suggest we use stable drivers for JM in CI and drop this workflow. |
As I wrote, I'm not currently using it. Also, I'm not planning to analyze CI failures for this workflow. I recommend you checking with @dkhaldi, regarding, if someone wants to take use/take it. Anyway, if you want my answer, I don't object regarding dropping this workflow. |
I don't look at failures because I was told by IGC they won't investigate or fix issues until they are in shipped IGC releases |
@dkhaldi, do you know if anyone is using IGC dev drivers and willing to handle issues uncovered by our CI? |
Yes, I look at CI failures in these PRs but ONLY for SYCL joint matrix tests. If there are failures, we set them to xfail and make sure we have a jira for them. If there are xpasses, it means the fix made it to IGC-dev so we remove the corresponding xfail. |
There are often other failures and the IGC team won't investigate them until they're in a release. How would you feel it we changed dev-igc testing here to only run joint matrix tests where you can investigate any failures? @dkhaldi |
I am okay with keeping dev-igc for joint matrix tests only if other components are fine without it. |
Thanks. Does the above sound okay with you guys as well @bader @aelovikov-intel? |
I'm fine assuming that @dkhaldi commits to address CI issues. |
I'll make the change. |
Only the Matrix team has committed to investigating failures on the IGC side. See discussion in #18818 Signed-off-by: Sarnie, Nick <[email protected]>
Closing this as newer dev driver PRs exist |
Scheduled igc dev drivers uplift