Skip to content

[GHA] Uplift Linux IGC Dev RT version to igc-dev-f8ec694 #18818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bb-sycl
Copy link
Contributor

@bb-sycl bb-sycl commented Jun 5, 2025

Scheduled igc dev drivers uplift

@bb-sycl bb-sycl requested review from a team as code owners June 5, 2025 03:24
@bb-sycl bb-sycl temporarily deployed to WindowsCILock June 5, 2025 03:24 — with GitHub Actions Inactive
@bb-sycl bb-sycl temporarily deployed to WindowsCILock June 5, 2025 03:48 — with GitHub Actions Inactive
@bb-sycl bb-sycl temporarily deployed to WindowsCILock June 5, 2025 03:48 — with GitHub Actions Inactive
@bader
Copy link
Contributor

bader commented Jun 12, 2025

@intel/dpcpp-devops-reviewers, it looks like no one really cares about igc-dev updates anymore. Can we disable GHA workflow for updating igc-dev?

@sarnex
Copy link
Contributor

sarnex commented Jun 12, 2025

Is it true that we don't care about igc-dev? @YuriPlyakhin @dkhaldi @jsji

If so I would really like to remove it from everything.

@jsji
Copy link
Contributor

jsji commented Jun 12, 2025

Is it true that we don't care about igc-dev? @YuriPlyakhin @dkhaldi @jsji

If so I would really like to remove it from everything.

The major user is joint-matrix team. If @YuriPlyakhin @dkhaldi don't care, then yes, we can remove it from pre-commit.

@YuriPlyakhin
Copy link
Contributor

Is it true that we don't care about igc-dev? @YuriPlyakhin @dkhaldi @jsji
If so I would really like to remove it from everything.

The major user is joint-matrix team. If @YuriPlyakhin @dkhaldi don't care, then yes, we can remove it from pre-commit.

I'm not currently actively working on Joint matrix, so I'll let @dkhaldi decide.
It was useful to me, when I was actively adding JM features to IGC, and then had to wait for months before I saw tests passing in SYCLOS with release drivers...

@bader
Copy link
Contributor

bader commented Jun 12, 2025

What I see is that no one from @intel/sycl-matrix-reviewers, @intel/dpcpp-esimd-reviewers and @intel/dpcpp-devops-reviewers groups look at the CI failures in these PRs.

GHA script creates PRs each week trying to update the driver version, but AFAIK @YuriPlyakhin is the only beneficiary of this script. If he is not going to analyze CI failures, I suggest we use stable drivers for JM in CI and drop this workflow.

@YuriPlyakhin
Copy link
Contributor

YuriPlyakhin commented Jun 12, 2025

What I see is that no one from @intel/sycl-matrix-reviewers, @intel/dpcpp-esimd-reviewers and @intel/dpcpp-devops-reviewers groups look at the CI failures in these PRs.

GHA script creates PRs each week trying to update the driver version, but AFAIK @YuriPlyakhin is the only beneficiary of this script. If he is not going to analyze CI failures, I suggest we use stable drivers for JM in CI and drop this workflow.

As I wrote, I'm not currently using it. Also, I'm not planning to analyze CI failures for this workflow. I recommend you checking with @dkhaldi, regarding, if someone wants to take use/take it. Anyway, if you want my answer, I don't object regarding dropping this workflow.

@sarnex
Copy link
Contributor

sarnex commented Jun 13, 2025

I don't look at failures because I was told by IGC they won't investigate or fix issues until they are in shipped IGC releases

@bader
Copy link
Contributor

bader commented Jul 11, 2025

What I see is that no one from @intel/sycl-matrix-reviewers, @intel/dpcpp-esimd-reviewers and @intel/dpcpp-devops-reviewers groups look at the CI failures in these PRs.
GHA script creates PRs each week trying to update the driver version, but AFAIK @YuriPlyakhin is the only beneficiary of this script. If he is not going to analyze CI failures, I suggest we use stable drivers for JM in CI and drop this workflow.

As I wrote, I'm not currently using it. Also, I'm not planning to analyze CI failures for this workflow. I recommend you checking with @dkhaldi, regarding, if someone wants to take use/take it. Anyway, if you want my answer, I don't object regarding dropping this workflow.

@dkhaldi, do you know if anyone is using IGC dev drivers and willing to handle issues uncovered by our CI?

@dkhaldi
Copy link
Contributor

dkhaldi commented Jul 14, 2025

What I see is that no one from @intel/sycl-matrix-reviewers, @intel/dpcpp-esimd-reviewers and @intel/dpcpp-devops-reviewers groups look at the CI failures in these PRs.
GHA script creates PRs each week trying to update the driver version, but AFAIK @YuriPlyakhin is the only beneficiary of this script. If he is not going to analyze CI failures, I suggest we use stable drivers for JM in CI and drop this workflow.

As I wrote, I'm not currently using it. Also, I'm not planning to analyze CI failures for this workflow. I recommend you checking with @dkhaldi, regarding, if someone wants to take use/take it. Anyway, if you want my answer, I don't object regarding dropping this workflow.

@dkhaldi, do you know if anyone is using IGC dev drivers and willing to handle issues uncovered by our CI?

Yes, I look at CI failures in these PRs but ONLY for SYCL joint matrix tests. If there are failures, we set them to xfail and make sure we have a jira for them. If there are xpasses, it means the fix made it to IGC-dev so we remove the corresponding xfail.

@sarnex
Copy link
Contributor

sarnex commented Jul 14, 2025

There are often other failures and the IGC team won't investigate them until they're in a release. How would you feel it we changed dev-igc testing here to only run joint matrix tests where you can investigate any failures? @dkhaldi

@dkhaldi
Copy link
Contributor

dkhaldi commented Jul 14, 2025

There are often other failures and the IGC team won't investigate them until they're in a release. How would you feel it we changed dev-igc testing here to only run joint matrix tests where you can investigate any failures? @dkhaldi

I am okay with keeping dev-igc for joint matrix tests only if other components are fine without it.

@sarnex
Copy link
Contributor

sarnex commented Jul 14, 2025

Thanks.

Does the above sound okay with you guys as well @bader @aelovikov-intel?

@bader
Copy link
Contributor

bader commented Jul 14, 2025

Thanks.

Does the above sound okay with you guys as well @bader @aelovikov-intel?

I'm fine assuming that @dkhaldi commits to address CI issues.

@sarnex
Copy link
Contributor

sarnex commented Jul 14, 2025

I'll make the change.

sarnex added a commit that referenced this pull request Jul 14, 2025
Only the Matrix team has committed to investigating failures on the IGC
side. See discussion in #18818

Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex
Copy link
Contributor

sarnex commented Jul 14, 2025

Closing this as newer dev driver PRs exist

@sarnex sarnex closed this Jul 14, 2025
@bader bader deleted the ci/update_gpu_driver-linux-igc-dev-f8ec694 branch July 14, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants