[SYCL][UR][L0 v2] Move all enqueue-related logic to command_list_manager#18837
Merged
kbenzie merged 4 commits intointel:syclfrom Jun 9, 2025
Merged
[SYCL][UR][L0 v2] Move all enqueue-related logic to command_list_manager#18837kbenzie merged 4 commits intointel:syclfrom
kbenzie merged 4 commits intointel:syclfrom
Conversation
Almost all in_order_queue functions are implemented by just forwarding the call to the command_list_manager. This is needed to implement out-of-order queue without duplicating the implementation.
all command list manager functions now expect ur_event_handle_t as signal event, not ur_event_handle_t*
Xewar313
reviewed
Jun 6, 2025
Contributor
Xewar313
left a comment
Xewar313
left a comment
There was a problem hiding this comment.
Overall makes sense, just a few nitpicks
Xewar313
reviewed
Jun 6, 2025
pbalcer
reviewed
Jun 6, 2025
EwanC
reviewed
Jun 6, 2025
pbalcer
approved these changes
Jun 6, 2025
EwanC
approved these changes
Jun 9, 2025
Contributor
Author
|
@intel/llvm-gatekeepers this is ready for merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Almost all in_order_queue functions are implemented by
just forwarding the call to the command_list_manager.
This is needed to implement out-of-order queue without
duplicating the implementation.