[UR] Ensure mock target depends on UR_EXTERNAL_DEPENDENCIES #18844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly, rename `ur_mock_headers` to `ur_mock` as this is a shared library not header only library. Secondly, when part of a subbuild, ensure that the `ur_mock` target depends on the specified `UR_EXTERNAL_DEPENDENCIES`, this is handled by using `add_ur_library()` in place of `add_library()`.
aarongreig
approved these changes
Jun 6, 2025
RossBrunton
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, rename
ur_mock_headerstour_mockas this is a shared library not header only library.Secondly, when part of a subbuild, ensure that the
ur_mocktarget depends on the specifiedUR_EXTERNAL_DEPENDENCIES, this is handled by usingadd_ur_library()in place ofadd_library().