[SYCL][E2E] Reduce number of FileCheck uses
#18848
Merged
+11
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LIT is perfectly capable of checking the exit code and there is no need to deal with any extra output parsing and I/O.
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| // RUN: env SYCL_PI_LEVEL_ZERO_TRACK_INDIRECT_ACCESS_MEMORY=1 %{run} %t.out 2>&1 | FileCheck %s | ||
| // | ||
| // CHECK: pass | ||
| // RUN: env SYCL_PI_LEVEL_ZERO_TRACK_INDIRECT_ACCESS_MEMORY=1 %{run} %t.out 2>&1 |
There was a problem hiding this comment.
I am not sure if this is the right PR to address this, but isn't SYCL_PI deprecated? Shouldn't this be SYCL_UR instead?
There was a problem hiding this comment.
All SYCL_PI variables still work, and there are no plans to deprecate them (at least in the L0v1 adapter).
There was a problem hiding this comment.
@pbalcer but do we have SYCL_UR equivalents? If so, I'd say we should go for SYCL_UR ones.
sarnex
approved these changes
Jun 11, 2025
uditagarwal97
approved these changes
Jun 11, 2025
asudarsa
reviewed
Jun 11, 2025
| @@ -87,12 +87,11 @@ int main(int argc, char **argv) { | |||
| passed = false; | |||
| } | |||
| } | |||
| std::cout << (passed ? "passed\n" : "FAILED\n"); | |||
| if (!passed) | |||
There was a problem hiding this comment.
In the same vein, why do we need to emit "FAILED"? Can we clean this up as well?
Thanks
There was a problem hiding this comment.
I can submit a follow-up PR for that: I'm less concerned about the negative path, since it is not expected to be triggered often.
pbalcer
approved these changes
Jun 24, 2025
AlexeySachkov
deleted the
private/asachkov/reduce-number-of-filecheck-uses-in-e2e-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LIT is perfectly capable of checking the exit code and there is no need to deal with any extra output parsing and I/O.