Skip to content

[CI][Bench] Add a filter to comparison scripts #18852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 10, 2025

Conversation

ianayl
Copy link
Contributor

@ianayl ianayl commented Jun 6, 2025

The nightly SYCL benchmarking CI currently fails on any benchmark. However, not all benchmarks are specific to SYCL. This PR adds a filter and sets the nightly SYCL CI to only fail on compute benchmark tests marked with _sycl.

Note to llvm-reviewers-benchmarking: Observe that changes to the code here are disconnected from the main benchmarking scripts. This PR should functionally have no effect on the main benchmarking scripts.

@ianayl ianayl temporarily deployed to WindowsCILock June 6, 2025 18:24 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock June 6, 2025 18:55 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock June 6, 2025 18:55 — with GitHub Actions Inactive
This reverts commit 68ad380.
@ianayl ianayl temporarily deployed to WindowsCILock June 6, 2025 19:41 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock June 6, 2025 20:01 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock June 6, 2025 20:01 — with GitHub Actions Inactive
@ianayl ianayl marked this pull request as ready for review June 6, 2025 21:46
@ianayl ianayl requested review from a team as code owners June 6, 2025 21:46
@ianayl
Copy link
Contributor Author

ianayl commented Jun 6, 2025

Test run here: https://github.com/intel/llvm/actions/runs/15495320467/job/43631091084#step:19:1296

Note that all non-sycl failures have been filtered out and will no longer trigger regression failures

@ianayl
Copy link
Contributor Author

ianayl commented Jun 10, 2025

@intel/dpcpp-devops-reviewers Could I get a review please? Thanks!

@ianayl
Copy link
Contributor Author

ianayl commented Jun 10, 2025

@intel/llvm-gatekeepers PR is ready for merge, thanks in advance!

@uditagarwal97 uditagarwal97 merged commit f713a06 into sycl Jun 10, 2025
24 checks passed
@uditagarwal97 uditagarwal97 deleted the ianayl/benchmark-ci-regression-filter branch June 10, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants