Skip to content

[UR][L0v2] Restrict events reset during command buffer enqueue #18990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from

Conversation

Xewar313
Copy link
Contributor

No description provided.

@Xewar313 Xewar313 requested a review from a team as a code owner June 16, 2025 12:28
@Xewar313 Xewar313 requested a review from reble June 16, 2025 12:28
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a UR CTS test already to stress this? Something where we create an out-of-order command buffer, with every command returning a sync-point, and then only use a subset of those sync-points to as dependencies in other commands.

@pbalcer
Copy link
Contributor

pbalcer commented Jun 16, 2025

Do we have a UR CTS test already to stress this? Something where we create an out-of-order command buffer, with every command returning a sync-point, and then only use a subset of those sync-points to as dependencies in other commands.

Sounds like this should be a benchmark, not a CTS test.

@Xewar313
Copy link
Contributor Author

Yea, I agree with Piotr, and I don't think that we have such benchmark yet

Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like this should be a benchmark, not a CTS test.

Yeah that's fair, my interest is more making sure that CI is verifying that the patch is functionality correct before it merges than knowing the perf benefit. But we have lots of SYCL E2E tests that create an out-of-order command-buffer with a sync point for every node, but won't use the sync points returned for leaf nodes, so this probably is being tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants