-
Notifications
You must be signed in to change notification settings - Fork 772
[UR][L0v2] Restrict events reset during command buffer enqueue #18990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
unified-runtime/source/adapters/level_zero/v2/command_buffer.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a UR CTS test already to stress this? Something where we create an out-of-order command buffer, with every command returning a sync-point, and then only use a subset of those sync-points to as dependencies in other commands.
Sounds like this should be a benchmark, not a CTS test. |
Yea, I agree with Piotr, and I don't think that we have such benchmark yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like this should be a benchmark, not a CTS test.
Yeah that's fair, my interest is more making sure that CI is verifying that the patch is functionality correct before it merges than knowing the perf benefit. But we have lots of SYCL E2E tests that create an out-of-order command-buffer with a sync point for every node, but won't use the sync points returned for leaf nodes, so this probably is being tested.
No description provided.