[SYCL][E2E] Fix -Werror failures in implicitly SPIR only DeviceLib tests

[Maetveis]

The -fsycl-device-lib-jit-link only has an effect in SPIR compilation so these tests would fail with -Werror for non SPIR targets.

This basically the same as #18985, but also apply it to tests that have UNSUPPORTED: target-amd || target-nvidia. These tests could be enabled for future non-SPIR targets; we should not be assuming that !target-amd && !target-nvidia implies SPIR.

[bader]

@aelovikov-intel, is there a cleaner way to handle the problem with %if?
If I get it right, we are supposed to add -fsycl-device-lib-jit-link only when we compile for spir target(s). I can't find similar examples in the existing tests. Do you know if there is a condition we can use e.g. %if spir %{-fsycl-device-lib-jit-link}?

[aelovikov-intel]

Not sure. We have something similar in

llvm/sycl/test-e2e/format.py

Lines 251 to 254 in 610d42a

	# TODO: Maybe that should be link-only option, so that we wouldn't
	# need to suppress the warning below for compile-only commands.
	sycl_target_opts += " -fsycl-use-spirv-backend-for-spirv-gen -Wno-unused-command-line-argument"
	substitutions.append(("%{sycl_target_opts}", sycl_target_opts))

And based on some lines above that there might be %if target-spir. If it doesn't work, then

llvm/sycl/test-e2e/format.py

Lines 343 to 357 in 610d42a

	conditions = {x: True for x in parsed_dev_name.split(":")}
	for cond_features in [
	"linux",
	"windows",
	"preview-breaking-changes-supported",
	]:
	if cond_features in test.config.available_features:
	conditions[cond_features] = True
	tmp_script = lit.TestRunner.applySubstitutions(
	tmp_script,
	[],
	conditions,
	recursion_limit=test.config.recursiveExpansionLimit,
	)

would be the place to debug, I think.

[bader]

This basically the same as #18985, but also apply it to tests that have UNSUPPORTED: target-amd || target-nvidia. These tests could be enabled for future non-SPIR targets; we should not be assuming that !target-amd && !target-nvidia implies SPIR.

We have REQUIRES: target-spir. Can we use it instead?

[aelovikov-intel]

We have REQUIRES: target-spir. Can we use it instead?

Are you asking me or @Maetveis ?

[bader]

We have REQUIRES: target-spir. Can we use it instead?

Are you asking me or @Maetveis ?

The author of the text from the PR description quoted in my comment.