Skip to content

[CI][sycl-rel] Change build image #19261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 7, 2025
Merged

[CI][sycl-rel] Change build image #19261

merged 5 commits into from
Jul 7, 2025

Conversation

KornevNikita
Copy link
Contributor

Our public releases should satisfy these requirements - https://vfxplatform.com
Among them - glibc 2.28. The best way to achieve it - is to use ASWF images, which already have the required env.

I've created a container based on aswf/ci-base:2025.1. The original image already contains CUDA SDK, but not ROCm. So I've additionally installed it using https://rocm.docs.amd.com/projects/install-on-linux/en/latest/install/quick-start.html for RHEL 8.10.

Our public releases should satisy these requrements - https://vfxplatform.com/
Among them - glibc 2.28. The best way to achieve it is to use ASWF
images, which already have the required env.

I've created a container based on aswf/ci-base:2025.1. The original
image already contains CUDA SDK, but not ROCm. So I've additionally
installed it using https://rocm.docs.amd.com/projects/install-on-linux/en/latest/install/quick-start.html
for RHEL 8.10.
@KornevNikita KornevNikita requested a review from a team as a code owner July 2, 2025 10:44
@KornevNikita
Copy link
Contributor Author

Test run: https://github.com/intel/llvm/actions/runs/16002988747 (I've disabled win as it's not affected. CUDA is ill).

@AlexeySachkov FYI

@intel/dpcpp-devops-reviewers this is kind of PoC. I believe it'd be better to have a workflow & scripts here in intel/llvm to create this container, and hence the container should be uploaded to intel/llvm, not to my fork. BUT, if you're OK with this solution, we can proceed with it and I'll create a follow-up patch.

build_configure_extra_args: '--disable-jit --no-assertions --add_security_flags=sanitize --hip --cuda'
build_image: ghcr.io/intel/llvm/ubuntu2204_build:latest-133fee559371ce0e6ff867e378c21cde2bdf6c90
build_configure_extra_args: '-DCMAKE_INSTALL_LIBDIR=lib --disable-jit --no-assertions --add_security_flags=sanitize --hip --cuda'
build_image: ghcr.io/kornevnikita/llvm:latest
Copy link
Contributor

@sarnex sarnex Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo we cant/shouldn't use images from forks. can you add this image to this repo? i would prefer we add it here before merging this PR, thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploaded to intel/llvm. Test is here https://github.com/intel/llvm/actions/runs/16032068467. I believe the result is fine, just windows runner & cuda are making their business.

@KornevNikita KornevNikita marked this pull request as draft July 2, 2025 16:39
@KornevNikita
Copy link
Contributor Author

KornevNikita commented Jul 2, 2025

Converted to draft to avoid merging before I test this one more time.

@KornevNikita KornevNikita marked this pull request as ready for review July 3, 2025 08:55
@KornevNikita KornevNikita requested a review from sarnex July 3, 2025 08:56
@KornevNikita
Copy link
Contributor Author

Lol back to draft. I guess there is no CUDA device due to some reason:D

@KornevNikita KornevNikita marked this pull request as draft July 3, 2025 12:09
@KornevNikita KornevNikita marked this pull request as ready for review July 7, 2025 09:50
@KornevNikita
Copy link
Contributor Author

CUDA should be fine now. This one is ready to merge, but please DO NOT MERGE IT BEFORE #19293

@@ -12,8 +12,8 @@ jobs:
with:
build_cache_root: "/__w/"
build_artifact_suffix: default
build_configure_extra_args: '--disable-jit --no-assertions --add_security_flags=sanitize --hip --cuda'
build_image: ghcr.io/intel/llvm/ubuntu2204_build:latest-133fee559371ce0e6ff867e378c21cde2bdf6c90
build_configure_extra_args: '-DCMAKE_INSTALL_LIBDIR=lib --disable-jit --no-assertions --add_security_flags=sanitize --hip --cuda'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use ${GITHUB_WORKSPACE}/lib ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lib is placed inside the "build" directory. If you want it to be more specific probably I can set the full path.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok nah then its fine

@sarnex sarnex merged commit 36ad906 into sycl-rel-6_2 Jul 7, 2025
17 of 19 checks passed
@bader bader deleted the release-container branch July 7, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants