Skip to content

[SYCL] Re-add removed symbols breaking ABI #19274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025

Conversation

DBDuncan
Copy link
Contributor

@DBDuncan DBDuncan commented Jul 2, 2025

These symbols were accidentality removed in #18851

These symbols were accidentily removed in intel#18851
@DBDuncan DBDuncan requested a review from a team as a code owner July 2, 2025 15:59
@DBDuncan DBDuncan requested a review from againull July 2, 2025 15:59
@DBDuncan
Copy link
Contributor Author

DBDuncan commented Jul 2, 2025

Note: Windows symbols have not been updated yet. Would have updated them already but our internal CI is acting up and is failing due to JITBinaryInfo.h being missing. Not sure what is causing that.

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@DBDuncan DBDuncan temporarily deployed to WindowsCILock July 3, 2025 10:54 — with GitHub Actions Inactive
@DBDuncan DBDuncan temporarily deployed to WindowsCILock July 3, 2025 11:22 — with GitHub Actions Inactive
@DBDuncan DBDuncan temporarily deployed to WindowsCILock July 3, 2025 11:22 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen merged commit 0e98f26 into intel:sycl Jul 3, 2025
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants