-
Notifications
You must be signed in to change notification settings - Fork 790
[SYCL][CMAKE] Only apply extra warnings to SYCL RT #19306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
[SYCL][CMAKE] Only apply extra warnings to SYCL RT #19306
Conversation
We can't enable all warnings globally, because LLVM itself isn't warning-free. Therefore, moved all necessary flags to the `sycl` subproject. There are more places where we need those extra flags, but they will be added there in separate PRs because in absolute cases it requires addional fixes to the codebase.
I'm a bit confused. How was this working up until now then? |
Once this configuration is buildable, it will be added to nightly. |
I see, thanks for the explanation! |
First attempt at BMG E2E testing failed, but the test passed on restart. I expect this patch to be a non-functional change, so I will proceed with the merge. Failed test:
|
Hm, doesn't this do the same? Line 112 in 29e7b63
|
Yeah, some cleanup is definitely due :) UPD: I think is that the piece of code I touched should be outlined into some macro to be re-used somewhere else |
We can't enable all warnings globally, because LLVM itself isn't warning-free. Therefore, moved all necessary flags to the
sycl
subproject.There are more places where we need those extra flags, but they will be added there in separate PRs because in absolute cases it requires addional fixes to the codebase.