[NFCI][SYCL][Graph] Refactor graph_impl::add
#19351
Open
+78
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and update the code surrounding their uses in the same spirit. Continuation of intel#19295 intel#19332 intel#19334
Part of the refactoring to eliminate `std::weak_ptr<node_impl>` and reduce usage of `std::shared_ptr<node_impl>` by preferring raw ptr/ref. Previous PRs in the series: intel#19295 intel#19332 intel#19334 intel#19350 * Accept `Deps` as `nodes_range` in `graph_impl::add` * Return `node_impl &` from `graph_impl::add` * Add `node` support in `nodes_range` and use that together with modified `graph_impl::add` when created new `node_impl`s based on `std::vector<node> Deps` to avoid creation of temporary `DepImpls` storage. * Also updated `registerSuccessor/registerPredecessor` and `addEventForNode/addDepsToNode` to accept raw `node_impl &` as the changes above resulted in having raw reference at the call sites.
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
force-pushed
the
add-overloads
branch
from
64069af to
395f476
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
commented
Jul 8, 2025
There was a problem hiding this comment.
Please ignore first commit - it's on review separately at #19350.
| @@ -442,7 +432,9 @@ graph_impl::add(std::function<void(handler &)> CGF, | |||
|
|
|||
| // Pass the node deps to the handler so they are available when processing the | |||
| // CGF, need for async_malloc nodes. | |||
| Handler.impl->MNodeDeps = Deps; | |||
| Handler.impl->MNodeDeps.clear(); | |||
There was a problem hiding this comment.
This is to preserve the semantics. Not sure if truly necessary, maybe there is a guarantee that it must be empty. And if not, why are we dropping old deps?
Comment on lines
+514
to
+516
| MNodeStorage.push_back( | ||
| std::make_shared<node_impl>(std::forward<Ts>(Args)...)); | ||
| return *MNodeStorage.back(); |
There was a problem hiding this comment.
Not sure if node_impl creation is under a mutex or not. If races are possible, then might need to change to
auto Ptr = make_shared();
node_impl &Res = *Ptr;
MNodeStorage.push_back(std::move(Ptr));
return Res;
If that's the case, then nodes_range over std::vector<node> optimization needs to be examined for the race conditions as well.
There was a problem hiding this comment.
Yes node_impl creation should always be under a mutex. Found a potential race and also gap in our e2e tests while investigating this: #19379
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the refactoring to eliminate
std::weak_ptr<node_impl>and reduce usage ofstd::shared_ptr<node_impl>by preferring raw ptr/ref. Previous PRs in the series:#19295
#19332
#19334
#19350
Depsasnodes_rangeingraph_impl::addnode_impl &fromgraph_impl::addnodesupport innodes_rangeand use that together with modifiedgraph_impl::addwhen created newnode_impls based onstd::vector<node> Depsto avoid creation of temporaryDepImplsstorage.registerSuccessor/registerPredecessorandaddEventForNode/addDepsToNodeto accept rawnode_impl &as the changes above resulted in having raw reference at the call sites.