[NativeCPU] Use host data layout. #19544
Open
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compilations without an aux target, the data layout string is not used by us because it only appears in device libs where it will be overwritten when the device lib gets merged in. For compilations with an aux target, the data layout string should be set to that of the aux target, the aux target may be relying on that.
|
cc @steffenlarsen, this should avoid the need for #19532, can you check that this works as expected for you too? |
coldav
approved these changes
Jul 22, 2025
|
Just a heads up that after today I will be on holiday, so if it can be reviewed today, great, otherwise if there is any feedback to address, it will have to wait a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compilations without an aux target, the data layout string is not used by us because it only appears in device libs where it will be overwritten when the device lib gets merged in.
For compilations with an aux target, the data layout string should be set to that of the aux target, the aux target may be relying on that.