-
Notifications
You must be signed in to change notification settings - Fork 807
[UR][L0][L0v2] Explicitly mark timestamped events #20247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
SYCL pre commit on CUDA fail is unrelated to this PR.
|
Hey @steffenlarsen, could you take a look please. |
Most recent CUDA run fails for known issue: #17650 in nested-non-packed-struct.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
2657352
to
0829524
Compare
I've mistakenly assumed that the PyTorch issue was with v1 adapter, but looking at the |
This is a workaround for a case where L0 driver fails to retrieve a timestamp but doesn't return an error. In such case, when event profiling info is queried we check the timestamp value and assume the event was not timestamped even though it was. This scenario can happen on newer platform with not yet full driver support.
SYCL Pre Commit on Windows fails with some CI host related issue:
I've re-run it a couple of times, but at each attempt, step 2 (Detect hung tests) has failed before even running the tests. I guess its a hung-up test from some job from other PR. |
This is a workaround for a case where L0 driver fails to retrieve a timestamp but doesn't return an error. In such case, when event profiling info is queried we check the timestamp value and assume the event was not timestamped even though it was.
This scenario can happen on newer platform with not yet full driver support.