Skip to content

Conversation

kswiecicki
Copy link
Contributor

This is a workaround for a case where L0 driver fails to retrieve a timestamp but doesn't return an error. In such case, when event profiling info is queried we check the timestamp value and assume the event was not timestamped even though it was.
This scenario can happen on newer platform with not yet full driver support.

@kswiecicki
Copy link
Contributor Author

SYCL pre commit on CUDA fail is unrelated to this PR.

Failed Tests (1):
  SYCL :: KernelCompiler/sycl_device_globals.cpp

@kswiecicki kswiecicki marked this pull request as ready for review September 30, 2025 11:22
@kswiecicki kswiecicki requested a review from a team as a code owner September 30, 2025 11:22
@kswiecicki
Copy link
Contributor Author

Hey @steffenlarsen, could you take a look please.

@steffenlarsen
Copy link
Contributor

Most recent CUDA run fails for known issue: #17650 in nested-non-packed-struct.cpp

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kswiecicki kswiecicki force-pushed the ur-l0-explicit-timestamp-flag branch from 2657352 to 0829524 Compare September 30, 2025 13:07
@kswiecicki
Copy link
Contributor Author

LGTM!

I've mistakenly assumed that the PyTorch issue was with v1 adapter, but looking at the sycl-ls logs, the L0 v2 adapter was used. I've included a corresponding v2 change in this patch.

@kswiecicki kswiecicki changed the title [UR][L0] Explicitly mark timestamped events [UR][L0][L0v2] Explicitly mark timestamped events Sep 30, 2025
This is a workaround for a case where L0 driver fails to retrieve a
timestamp but doesn't return an error. In such case, when event
profiling info is queried we check the timestamp value and assume the
event was not timestamped even though it was.
This scenario can happen on newer platform with not yet full driver
support.
@kswiecicki
Copy link
Contributor Author

SYCL Pre Commit on Windows fails with some CI host related issue:

Run Invoke-WebRequest -Uri "https://raw.githubusercontent.com/intel/llvm/refs/heads/sycl/devops/scripts/windows_detect_hung_tests.ps1" -OutFile "windows_detect_hung_tests.ps1" -Headers @{Authorization = "***"}
Test d:\github\_work\llvm\llvm\build-e2e\hostinteroptask\output\host-task-failure.cpp.tmp.out hung!
End Process failed for [8](https://github.com/intel/llvm/actions/runs/18130923540/job/51599696027?pr=20247#step:2:9)048:Access is denied.

I've re-run it a couple of times, but at each attempt, step 2 (Detect hung tests) has failed before even running the tests. I guess its a hung-up test from some job from other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants