Tags: intel/llvm
Tags
Merged to sycl-web with no conflict or build issue
HALT Build failed after merge .: (from main) commit 9eef4d1 Author: Aaron Ballman <[email protected]> Date: Fri Jun 13 06:45:40 2025 -0400 Remove delayed typo expressions (#143423) This removes the delayed typo correction functionality from Clang (regular typo correction still remains) due to fragility of the solution. An RFC was posted here: https://discourse.llvm.org/t/rfc-removing-support-for-delayed-typo-correction/86631 and while that RFC was asking for folks to consider stepping up to be maintainers, and we did have a few new contributors show some interest, experiments show that it's likely worth it to remove this functionality entirely and focus efforts on improving regular typo correction. This removal fixes ~20 open issues (quite possibly more), improves compile time performance by roughly .3-.4% (https://llvm-compile-time-tracker.com/?config=Overview&stat=instructions%3Au&remote=AaronBallman&sortBy=date), and does not appear to regress diagnostic behavior in a way we wouldn't find acceptable. Fixes #142457 Fixes #139913 Fixes #138850 Fixes #137867 Fixes #137860 Fixes #107840 Fixes #93308 Fixes #69470 Fixes #59391 Fixes #58172 Fixes #46215 Fixes #45915 Fixes #45891 Fixes #44490 Fixes #36703 Fixes #32903 Fixes #23312 Fixes #69874 Affected files: clang-tools-extra/clangd/unittests/HoverTests.cpp clang/docs/HIPSupport.rst clang/docs/ReleaseNotes.rst clang/include/clang/AST/Expr.h clang/include/clang/AST/RecursiveASTVisitor.h clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Basic/StmtNodes.td clang/include/clang/CIR/MissingFeatures.h clang/include/clang/Parse/Parser.h clang/include/clang/Sema/Sema.h clang/include/clang/Sema/SemaInternal.h clang/lib/AST/Expr.cpp clang/lib/AST/ExprClassification.cpp clang/lib/AST/ExprConstant.cpp clang/lib/AST/ItaniumMangle.cpp clang/lib/AST/StmtPrinter.cpp clang/lib/AST/StmtProfile.cpp clang/lib/CIR/CodeGen/CIRGenBuilder.h clang/lib/CIR/CodeGen/CIRGenCall.cpp clang/lib/CIR/CodeGen/CIRGenCall.h clang/lib/CIR/CodeGen/CIRGenExpr.cpp clang/lib/CIR/CodeGen/CIRGenExprAggregate.cpp clang/lib/CIR/CodeGen/CIRGenFunction.cpp clang/lib/CIR/CodeGen/CIRGenFunction.h clang/lib/CIR/CodeGen/CIRGenValue.h clang/lib/Parse/ParseCXXInlineMethods.cpp clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp clang/lib/Parse/ParseExpr.cpp clang/lib/Parse/ParseExprCXX.cpp clang/lib/Parse/ParseInit.cpp clang/lib/Parse/ParseObjc.cpp clang/lib/Parse/ParseOpenACC.cpp clang/lib/Parse/ParseOpenMP.cpp clang/lib/Parse/ParseStmt.cpp clang/lib/Parse/ParseStmtAsm.cpp clang/lib/Parse/ParseTemplate.cpp clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaChecking.cpp clang/lib/Sema/SemaCoroutine.cpp clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaDeclCXX.cpp clang/lib/Sema/SemaExceptionSpec.cpp clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaExprCXX.cpp clang/lib/Sema/SemaExprMember.cpp clang/lib/Sema/SemaLookup.cpp clang/lib/Sema/SemaObjC.cpp clang/lib/Sema/SemaOverload.cpp clang/lib/Sema/SemaStmt.cpp clang/lib/Sema/SemaStmtAttr.cpp clang/lib/Sema/SemaTemplateVariadic.cpp clang/lib/Sema/SemaTypeTraits.cpp clang/lib/Sema/TreeTransform.h clang/lib/Serialization/ASTReaderStmt.cpp clang/lib/Serialization/ASTWriterStmt.cpp clang/lib/StaticAnalyzer/Core/ExprEngine.cpp clang/test/AST/ByteCode/literals.cpp clang/test/AST/ast-dump-recovery.c clang/test/AST/ast-dump-recovery.cpp clang/test/AST/ast-dump-recovery.m clang/test/CIR/CodeGen/call.c clang/test/CIR/CodeGen/call.cpp clang/test/CXX/drs/cwg18xx.cpp clang/test/CXX/drs/cwg1xx.cpp clang/test/CXX/drs/cwg26xx.cpp clang/test/CXX/module/basic/basic.link/p2.cppm clang/test/FixIt/typo.cpp clang/test/Format/multiple-inputs-error.cpp clang/test/Format/ranges.cpp clang/test/Index/complete-switch.c clang/test/Index/fix-its.c clang/test/Lexer/raw-string-ext.c clang/test/Modules/diagnose-missing-import.m clang/test/OpenMP/begin_declare_variant_messages.c clang/test/OpenMP/declare_reduction_messages.cpp clang/test/OpenMP/declare_variant_messages.c clang/test/OpenMP/declare_variant_messages.cpp clang/test/OpenMP/target_update_messages.cpp clang/test/Parser/cxx1z-decomposition.cpp clang/test/Parser/cxx1z-fold-expressions.cpp clang/test/Parser/cxx2c-pack-indexing.cpp clang/test/Parser/objc-foreach-syntax.m clang/test/Parser/opencl-atomics-cl20.cl clang/test/Parser/recovery.c clang/test/Parser/switch-recovery.cpp clang/test/Parser/switch-typo-correction.cpp clang/test/ParserOpenACC/parse-cache-construct.cpp clang/test/ParserOpenACC/parse-clauses.c clang/test/ParserOpenACC/parse-constructs.cpp clang/test/ParserOpenACC/parse-wait-clause.c clang/test/ParserOpenACC/parse-wait-construct.c clang/test/Sema/PR28181.c clang/test/Sema/builtin-unary-fp.c clang/test/Sema/c23-delayed-typo-correction-crashes.c clang/test/Sema/delayed-typo-correction-crashes.c clang/test/Sema/invalid-member.cpp clang/test/Sema/typo-correction-ambiguity.cpp clang/test/Sema/typo-correction-no-hang.c clang/test/Sema/typo-correction-no-hang.cpp clang/test/Sema/typo-correction-recursive.cpp clang/test/Sema/typo-correction.c clang/test/SemaCXX/arrow-operator.cpp clang/test/SemaCXX/constant-expression-cxx11.cpp clang/test/SemaCXX/conversion-function.cpp clang/test/SemaCXX/coroutines.cpp clang/test/SemaCXX/cxx-delayed-typo-correction-crashes.cpp clang/test/SemaCXX/cxx1z-decomposition.cpp clang/test/SemaCXX/cxx20-delayed-typo-correction-crashes.cpp clang/test/SemaCXX/cxx2a-adl-only-template-id.cpp clang/test/SemaCXX/destructor.cpp clang/test/SemaCXX/invalid-if-constexpr.cpp clang/test/SemaCXX/member-expr.cpp clang/test/SemaCXX/nested-name-spec.cpp clang/test/SemaCXX/overload-resolution-deferred-templates.cpp clang/test/SemaCXX/pr13394-crash-on-invalid.cpp clang/test/SemaCXX/return.cpp clang/test/SemaCXX/type-traits-unsatisfied-diags-std.cpp clang/test/SemaCXX/type-traits-unsatisfied-diags.cpp clang/test/SemaCXX/typo-correction-crash.cpp clang/test/SemaCXX/typo-correction-cxx11.cpp clang/test/SemaCXX/typo-correction-delayed.cpp clang/test/SemaCXX/typo-correction.cpp clang/test/SemaCXX/virtuals.cpp clang/test/SemaObjC/call-super-2.m clang/test/SemaObjC/typo-correction-subscript.m clang/test/SemaObjC/undef-arg-super-method-call.m clang/test/SemaObjCXX/block-for-lambda-conversion.mm clang/test/SemaOpenACC/compute-construct-num_gangs-clause.cpp clang/test/SemaOpenCL/atomic-ops.cl clang/test/SemaOpenCL/clang-builtin-version.cl clang/test/SemaTemplate/concepts-recovery-expr.cpp clang/test/SemaTemplate/concepts.cpp clang/test/SemaTemplate/typo-variadic.cpp clang/tools/clang-format/ClangFormat.cpp clang/tools/libclang/CXCursor.cpp clang/unittests/Sema/ExternalSemaSourceTest.cpp compiler-rt/lib/fuzzer/FuzzerDataFlowTrace.cpp flang-rt/lib/cuda/descriptor.cpp flang/include/flang/Lower/LoweringOptions.def flang/include/flang/Optimizer/Builder/Runtime/CUDA/Descriptor.h flang/include/flang/Runtime/CUDA/descriptor.h flang/lib/Lower/ConvertCall.cpp flang/lib/Optimizer/Builder/Runtime/CUDA/Descriptor.cpp flang/test/Lower/CUDA/cuda-runtime-check.cuf flang/test/Lower/OpenMP/flush02.f90 flang/tools/bbc/bbc.cpp lld/ELF/Arch/AArch64.cpp lld/ELF/Config.h lld/ELF/Driver.cpp lld/ELF/InputFiles.cpp lld/ELF/InputFiles.h lld/ELF/Symbols.cpp lld/ELF/SyntheticSections.cpp lld/ELF/Writer.cpp lld/docs/ReleaseNotes.rst lld/docs/ld.lld.1 lld/test/ELF/aarch64-feature-pauth.s lld/test/ELF/driver.test lld/test/ELF/weak-undef-got-plt.s lld/test/ELF/weak-undef-hidden.s lld/test/ELF/weak-undef-rw.s lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py lldb/test/API/api/multiple-debuggers/multi-process-driver.cpp llvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst llvm/docs/AMDGPUUsage.rst llvm/lib/IR/LLVMContextImpl.h llvm/lib/Target/AArch64/AArch64ISelLowering.cpp llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp llvm/lib/Target/NVPTX/NVPTXISelDAGToDAG.cpp llvm/lib/Target/NVPTX/NVPTXISelDAGToDAG.h llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp llvm/lib/Target/NVPTX/NVPTXISelLowering.h llvm/lib/Target/NVPTX/NVPTXInstrInfo.td llvm/lib/Target/NVPTX/NVPTXIntrinsics.td llvm/lib/Target/RISCV/RISCVFeatures.td llvm/lib/Target/RISCV/RISCVISelLowering.cpp llvm/lib/Target/RISCV/RISCVProcessors.td llvm/lib/Target/RISCV/RISCVSubtarget.h llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp llvm/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp llvm/lib/Target/Sparc/MCTargetDesc/SparcMCAsmInfo.cpp llvm/lib/Target/Sparc/MCTargetDesc/SparcMCCodeEmitter.cpp llvm/lib/Target/Sparc/MCTargetDesc/SparcMCExpr.cpp llvm/lib/Target/Sparc/MCTargetDesc/SparcMCExpr.h llvm/lib/Target/Sparc/SparcAsmPrinter.cpp llvm/lib/Target/Sparc/SparcTargetObjectFile.cpp llvm/lib/Target/X86/X86FixupInstTuning.cpp llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp llvm/lib/Transforms/InstCombine/InstCombineInternal.h llvm/lib/Transforms/InstCombine/InstructionCombining.cpp llvm/lib/Transforms/Scalar/GVN.cpp llvm/lib/Transforms/Vectorize/LoopVectorize.cpp llvm/lib/Transforms/Vectorize/VPlan.cpp llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp llvm/test/Analysis/KernelInfo/openmp/amdgpu.ll llvm/test/CodeGen/AArch64/aarch64-sme2-asm.ll llvm/test/CodeGen/AMDGPU/mad_64_32.ll llvm/test/CodeGen/AMDGPU/srl64_reduce.ll llvm/test/CodeGen/NVPTX/fast-math.ll llvm/test/CodeGen/NVPTX/prmt.ll llvm/test/CodeGen/NVPTX/sqrt-approx.ll llvm/test/CodeGen/RISCV/features-info.ll llvm/test/CodeGen/RISCV/memcmp-optsize.ll llvm/test/CodeGen/RISCV/memcmp.ll llvm/test/CodeGen/X86/avx-insertelt.ll llvm/test/CodeGen/X86/avx-intrinsics-x86-upgrade.ll llvm/test/CodeGen/X86/coalesce_commute_movsd.ll llvm/test/CodeGen/X86/combine-and.ll llvm/test/CodeGen/X86/combine-or-shuffle.ll llvm/test/CodeGen/X86/commute-blend-sse41.ll llvm/test/CodeGen/X86/horizontal-sum.ll llvm/test/CodeGen/X86/insertelement-zero.ll llvm/test/CodeGen/X86/masked_expandload.ll llvm/test/CodeGen/X86/masked_load.ll llvm/test/CodeGen/X86/sse-insertelt-from-mem.ll llvm/test/CodeGen/X86/sse-insertelt.ll llvm/test/CodeGen/X86/sse-scalar-fp-arith.ll llvm/test/CodeGen/X86/sse2-intrinsics-fast-isel.ll llvm/test/CodeGen/X86/sse2-intrinsics-x86-upgrade.ll llvm/test/CodeGen/X86/sse2.ll llvm/test/CodeGen/X86/sse41-intrinsics-fast-isel.ll llvm/test/CodeGen/X86/sse41-intrinsics-x86-upgrade.ll llvm/test/CodeGen/X86/sse41.ll llvm/test/CodeGen/X86/vec-strict-128-fp16.ll llvm/test/CodeGen/X86/vec_floor.ll llvm/test/CodeGen/X86/vector-blend.ll llvm/test/CodeGen/X86/vector-interleaved-load-i32-stride-4.ll llvm/test/CodeGen/X86/vector-interleaved-load-i32-stride-5.ll llvm/test/CodeGen/X86/vector-mul.ll llvm/test/CodeGen/X86/vector-shuffle-128-v2.ll llvm/test/CodeGen/X86/vector-shuffle-128-v4.ll llvm/test/CodeGen/X86/vector-shuffle-256-v8.ll llvm/test/CodeGen/X86/vector-shuffle-combining-ssse3.ll llvm/test/CodeGen/X86/vector-shuffle-concatenation.ll llvm/test/CodeGen/X86/vector-zmov.ll llvm/test/CodeGen/X86/vselect-2.ll llvm/test/CodeGen/X86/vselect.ll llvm/test/Transforms/GVN/opt-remark-assert-constant-uselistorder.ll llvm/test/Transforms/InstCombine/sub-gep.ll llvm/test/Transforms/LoopVectorize/check-prof-info.ll llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp mlir/include/mlir/Conversion/LLVMCommon/Pattern.h mlir/include/mlir/Dialect/AMDGPU/IR/AMDGPU.td mlir/include/mlir/Dialect/LLVMIR/ROCDLDialect.h mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp mlir/lib/Dialect/AMDGPU/IR/AMDGPUDialect.cpp mlir/lib/Dialect/AMX/Transforms/LegalizeForLLVMExport.cpp mlir/lib/Dialect/Linalg/Transforms/ElementwiseOpFusion.cpp mlir/lib/Dialect/Linalg/Transforms/WinogradConv2D.cpp mlir/lib/Dialect/X86Vector/Transforms/LegalizeForLLVMExport.cpp mlir/test/Conversion/AMDGPUToROCDL/packed-ext.mlir mlir/test/Conversion/AMDGPUToROCDL/packed-trunc.mlir mlir/test/Dialect/AMDGPU/ops.mlir mlir/test/Dialect/Linalg/fusion-elementwise-ops.mlir mlir/test/Dialect/Linalg/transform-winograd-conv2d.mlir polly/lib/Support/RegisterPasses.cpp Notify: [email protected]
Merged to sycl-web with no conflict or build issue
[SYCL] Fix reductions in preview after #18767 (#18898) As a matter of fact, I like this even more, because `type_erased_cgfo_ty` is cheap to create/pass around, we have full access to `handler_impl` in `handler.cpp` (unlike `handler.hpp` where it's opaque) and circular includes/type completeness aren't an issue anymore.
[SYCL] use vector instead of map as a kernel cache container (#18833) We assume that in most cases, there is only a single context/device per kernel. Considering that using a vector instead of the hash map performs better on a common case scenarios.
PreviousNext