-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Update module to work with any repo. #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We don't publish DEVs .whl. |
1 similar comment
We don't publish DEVs .whl. |
We don't publish DEVs .whl. |
1 similar comment
We don't publish DEVs .whl. |
We don't publish DEVs .whl. |
1 similar comment
We don't publish DEVs .whl. |
We don't publish DEVs .whl. |
1 similar comment
We don't publish DEVs .whl. |
We don't publish DEVs .whl. |
We don't publish DEVs .whl. |
We don't publish DEVs .whl. |
1 similar comment
We don't publish DEVs .whl. |
We don't publish DEVs .whl. |
1 similar comment
We don't publish DEVs .whl. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the mfd-code-quality module to work with any repository, making it more generic and flexible. The changes remove MFD-specific dependencies and improve the user experience with better logging and configuration management.
- Rename functions and modules to be more generic (e.g.,
import_testing
→import_tests
,pkg_to_include_in_cov
→get_package_name
) - Implement dynamic package discovery using
setuptools.find_packages
instead of hardcoded MFD patterns - Add enhanced logging with custom formatter and verbose mode support
- Update command-line interface with new script names and better help documentation
Reviewed Changes
Copilot reviewed 21 out of 25 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
mfd_code_quality/utils.py | Added generic package discovery function and improved logging setup |
mfd_code_quality/testing_utilities/import_tests.py | Renamed from import_testing.py and updated to use generic package discovery |
mfd_code_quality/testing_utilities/unit_tests.py | Updated to use new package discovery function |
mfd_code_quality/code_standard/configure.py | Refactored module name detection to work with any repository |
pyproject.toml | Updated script entry points and removed pre-commit config file |
tests/* | Updated test files to reflect renamed modules and functions |
Comments suppressed due to low confidence (1)
tests/unit/test_mfd_code_quality/test_coverage/test_utils.py:14
- The test is mocking CompletedProcess with stdout and stderr parameters, but it's not clear if the actual function under test uses these parameters. Consider verifying that the test accurately reflects the real behavior.
)
Signed-off-by: Mateusz Chrominski <[email protected]>
We don't publish DEVs .whl. |
1 similar comment
We don't publish DEVs .whl. |
https://github.com/intel/mfd-code-quality/tree/ref?tab=readme-ov-file