-
Notifications
You must be signed in to change notification settings - Fork 45
Report import failure error code #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ovep-develop
Are you sure you want to change the base?
Conversation
7dbe8e9
to
faf1a6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javier-intel .. DO we have a way to trigger compatibility failure and ensure exception triggered by elf loader and UMD is caught here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a structured exception type to surface import failures with specific error codes and adjusts OpenVINO provider components to catch and convert these exceptions into ORT statuses or trigger CPU fallback.
- Added
ovep_exception
to parse OpenVINO errors and map them tocommon::Status
. - Updated
OVCore::ImportModel
to throwovep_exception
on import failures. - Wrapped compilation and backend manager logic to catch
ovep_exception
and handle fallback or status conversion.
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
onnxruntime/core/providers/openvino/ov_interface.cc | Imported exceptions.h and replaced generic throw with ovep_exception in ImportModel |
onnxruntime/core/providers/openvino/openvino_execution_provider.cc | Added try/catch around Compile to convert ovep_exception into Status |
onnxruntime/core/providers/openvino/exceptions.h | New exception class ovep_exception for parsing error codes and mapping to ORT statuses |
onnxruntime/core/providers/openvino/backend_manager.cc | Switched to catching ovep_exception and refined NPU fallback handling |
…r.cc Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
c75e346
to
64bcdad
Compare
Description
Report invalid binary when context model can't be imported by OV
Motivation and Context
Correctly communicate to ORT core the failure to import EpCtx
https://jira.devtools.intel.com/browse/CVS-167480