WIP: ci: Verify mapfile.csv metric entries #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit expands mapfile checks for metric files. The goal is to avoid deleting or forgetting mapfile.csv entries for metric files. See [1] for an example. [1] intel#312
Add entries for TGL/metrics/tigerlake_metrics.json.
This commit ignores missing references for sapphirerapidshbm_metrics.json. Sapphire Rapids products, including HBM models, use 0x8F. Entries in mapfile.csv point to the main sapphirerapids_metrics.json.
Add mapfile.csv entries for ADL GLC metrics.
Add mapfile.csv entries for MTL RWC metrics.
Add mapfile.csv entries for MTL LNC metrics.
Add mapfile.csv entries for ARL LNC metrics.
edwarddavidbaker
requested review from
kshiprab,
1perrytaylor and
calebbiggers
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request expands automated
mapfile.csvchecks. Specifically focusing on content such as https://github.com/intel/perfmon/blob/main/GNR/metrics/graniterapids_retire_latency.json and https://github.com/intel/perfmon/blob/main/GNR/metrics/graniterapids_metrics.json . The goal is to prevent accidents when updatingmapfile.csv. See #312 as an example where I previously dropped retire latency data.**/metrics/*.jsonare mentioned inmapfile.csv.GenuineIntel-6-BEmissingalderlake_metrics_goldencove_core.jsonare ignored. ADL-N is an E-Core only product.sapphirerapidshbm_metrics.jsonare ignored. Onlysapphirerapids_metrics.jsonwill be mentioned inmapfile.csv.Follow-up commits add missing files to
mapfile.csvas identified by this check.