This repository was archived by the owner on Mar 14, 2020. It is now read-only.
Integration 20120831 #284
Closed
Integration 20120831 #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can define a "morph" function for a zone so that When adding a child, it can be morphed to another type. With this feature, we can have a generic widget in the palette which can adapt to different types of containers when dropped on them.
Looking for parent zone with the same name. If found, extend it with descendant zone, otherwize add a new zone.
Also set the default value of count bubble to empty, i.e, no count bubble
Sorting is still OK without this change and it causes bad appearance of ButtonGroup and ThumbnailSplitList
Previous algorithm only supports one zone containers or Headers, and it works hard to determine the position for insertion. The new algorithm firstly tries to insert to the zone of the nearest sibling using enhenced insertChildAfter/Before, if fails, uses addChild to automatically find a zone to insert.
In Google Chrome 15.0.874.121, the upload dialog can't show if we use the parent of the clicked item
Conflicts: src/js/composer.js
|
I reverted the event handler patch in a 'stable' branch and published Preview-2 based on that. But I left it in, in master, and added the lists patch. All the other good bug-fixes patches I merged into both. Only a couple didn't make it, see comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#275, #274, #283, #280, #279, #278, #277, #276, #270 included.
#282 is included in lists(#274). If lists can't get in, you can put #282 in separately