Skip to content

fix Windows cmake for BUILD_SEPARATE_OPS #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix Windows cmake for BUILD_SEPARATE_OPS #2147

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
248d6c0
add print dispatch
xuhancn Oct 10, 2025
2960869
update code.
xuhancn Oct 10, 2025
d6ce302
update code
xuhancn Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/BuildOnWindows.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ macro(setup_common_libraries)
torch_xpu_ops
STATIC
${ATen_XPU_CPP_SRCS})
set(PATH_TO_TORCH_XPU_OPS_ATEN_LIB \"torch_xpu_ops_aten.dll\")
target_compile_options(torch_xpu_ops PRIVATE -DPATH_TO_TORCH_XPU_OPS_ATEN_LIB=${PATH_TO_TORCH_XPU_OPS_ATEN_LIB})


add_library(
torch_xpu_ops_aten
Expand All @@ -25,6 +24,7 @@ macro(setup_common_libraries)
endmacro()

if(BUILD_SEPARATE_OPS)
message("!!!!! BUILD_SEPARATE_OPS: ${BUILD_SEPARATE_OPS} - 1")
setup_common_libraries()
foreach(sycl_src ${ATen_XPU_SYCL_SRCS})
get_filename_component(name ${sycl_src} NAME_WLE REALPATH)
Expand All @@ -33,6 +33,8 @@ if(BUILD_SEPARATE_OPS)
${sycl_lib}
SHARED
SYCL_SOURCES ${sycl_src})
target_link_libraries(${sycl_lib} PUBLIC torch_xpu)
target_link_libraries(${sycl_lib} PUBLIC torch_xpu_ops)
target_link_libraries(torch_xpu_ops_aten PUBLIC ${sycl_lib})
list(APPEND TORCH_XPU_OPS_LIBRARIES ${sycl_lib})

Expand All @@ -44,6 +46,7 @@ if(BUILD_SEPARATE_OPS)
# Working with the compilers which don't support device code compression, we have to split kernels
# into multiple libraries to meet the bin size limitation.
elseif(BUILD_SPLIT_KERNEL_LIB OR __INTEL_LLVM_COMPILER LESS 20250004 OR ICX_DATE LESS 20241205)
message("!!!!! BUILD_SEPARATE_OPS: ${BUILD_SEPARATE_OPS} - 2")
setup_common_libraries()
# Split SYCL kernels into 2 libraries as categories 1) Unary+Binary 2) Others.
set(ATen_XPU_SYCL_BINARY_SRCS)
Expand Down Expand Up @@ -242,6 +245,7 @@ elseif(BUILD_SPLIT_KERNEL_LIB OR __INTEL_LLVM_COMPILER LESS 20250004 OR ICX_DATE
list(APPEND TORCH_XPU_OPS_LIBRARIES torch_xpu_ops)
list(APPEND TORCH_XPU_OPS_LIBRARIES torch_xpu_ops_aten)
else()
message("!!!!! BUILD_SEPARATE_OPS: ${BUILD_SEPARATE_OPS} - 3")
# On Windows, it is not possible to combine all obj files into one library
# because the obj files of kernels compiled on Windows are much larger than
# those on Linux. If they are combined into one, the library size will exceed
Expand Down
Loading