fix(dashboard): MCP ingestion 422 errors — wrong parameter name#4
Conversation
…oint
Dashboard was sending {feed_id: "hackernews"} but the MCP service expects
{feed_url: "https://..."} — causing 422 validation errors on every ingestion.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello @jeremylongshore, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and resolves a critical issue where the dashboard's RSS feed ingestion and a related documentation example were failing due to an incorrect parameter name. By standardizing the parameter from Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 WalkthroughWalkthroughThe RSS feed ingestion configuration is updated to use URL-based sources instead of feed identifiers. The feed URL is changed to "https://news.ycombinator.com/rss" across multiple files, with additional parameters for limiting items and time windows added to the request payload. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly resolves a 422 Unprocessable Entity error that occurred when triggering ingestion from the dashboard. The issue was due to an incorrect parameter name being sent to the MCP service. The fix involves changing feed_id to feed_url in the request payload within dashboard/src/pages/Dashboard.tsx and also updating an incorrect curl example in CLAUDE.md. The changes are accurate and effectively address the bug. I have provided one suggestion to improve code maintainability by extracting hardcoded values into constants.
| method: 'POST', | ||
| headers: { 'Content-Type': 'application/json' }, | ||
| body: JSON.stringify({ feed_id: 'hackernews' }) | ||
| body: JSON.stringify({ feed_url: 'https://news.ycombinator.com/rss', time_window_hours: 24, max_items: 50 }) |
There was a problem hiding this comment.
While this change correctly fixes the ingestion error, it introduces hardcoded values for the feed URL and ingestion parameters. To improve maintainability and readability, it's better to define these as constants at the top of the file, similar to how MCP_URL is defined.
For example, you could add these constants:
const HACKERNEWS_RSS_URL = 'https://news.ycombinator.com/rss';
const INGESTION_TIME_WINDOW_HOURS = 24;
const INGESTION_MAX_ITEMS = 50;Then, you can use them in the fetch call as suggested.
| body: JSON.stringify({ feed_url: 'https://news.ycombinator.com/rss', time_window_hours: 24, max_items: 50 }) | |
| body: JSON.stringify({ feed_url: HACKERNEWS_RSS_URL, time_window_hours: INGESTION_TIME_WINDOW_HOURS, max_items: INGESTION_MAX_ITEMS }) |
1 participant
Summary
{"feed_id": "hackernews"}to the MCP serviceFetchRSSFeedRequestschema requiresfeed_url(a real URL), notfeed_idRoot cause: Parameter mismatch introduced in commit 1911c70
Test plan
curl -X POST .../mcp/tools/fetch_rss_feed -H "Content-Type: application/json" -d '{"feed_url": "https://news.ycombinator.com/rss", "max_items": 10}'🤖 Generated with Claude Code
Summary by CodeRabbit